Closed Bug 1667339 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25785 - [PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints

Categories

(Core :: Audio/Video: Recording, task, P4)

Product:
Core
Component:
Audio/Video: Recording
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25785 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25785
Details from upstream follow.

b'Francois Beaufort <beaufort.francois@gmail.com>' wrote:

[PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints

This PR makes sure required PTZ constraints in the basic constraint set
are denied (and throw a TypeError) and PTZ capability constraints
({ zoom: true } etc.) are ideal in the basic constraint set.
Therefore, a PTZ constraint in the basic set cannot cause getUserMedia()
to fail conditionally.

Spec:
https://github.com/w3c/mediacapture-image/pull/261
https://github.com/w3c/mediacapture-main/pull/707/

Bug: 934063
Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b

Reviewed-on: https://chromium-review.googlesource.com/2411946
WPT-Export-Revision: a728525f50973d9242f5f5288902d09d9bd3819b

Component: web-platform-tests → Audio/Video: Recording
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
FAIL: 9

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/mediacapture-image/getusermedia.https.html
getUserMedia({"video":{"pan":{"min":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"pan":{"max":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"pan":{"exact":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"tilt":{"min":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"tilt":{"max":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"tilt":{"exact":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"zoom":{"min":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"zoom":{"max":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)
getUserMedia({"video":{"zoom":{"exact":1}}}) must fail with TypeError: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52b5ab9dbd78 [wpt PR 25785] - [PTZ] Deny mandatory PTZ constraints in basic getUserMedia constraints, a=testonly https://hg.mozilla.org/integration/autoland/rev/9f21aac50177 [wpt PR 25785] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/52b5ab9dbd78
https://hg.mozilla.org/mozilla-central/rev/9f21aac50177

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.