1667351 - After the cert authentication we do not call neqo's process immediately

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Dragana Damjanovic [:dragana]]

This you use to work properly, but when we have split process_output and process_input this step is missed.
When a cert is authenticated we call neqo's Authenticated function but we do not call ProcessEvent so we do not pick up promptly that the connection is now ready or failed. We relay on timers to prompt the call.

This just adds unnecessary delay of 1 PTO.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: Process neqo events immediately after a cert authentication is done.

Currently we call ResumeSend() which will not process neqo events. It will only produce new packets. We are relying on other events, like timeout or a receive packet to trigger this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dd604f6e395
Process neqo events immediately after a cert authentication is done. r=necko-reviewers,valentin

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4dd604f6e395

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 4dd604f6e395 (bug 1667351) for causing high frequency xpcshell failures at test_altsvc_pref.js.
https://hg.mozilla.org/integration/autoland/rev/e29c5f0e349d9bd193f4076f81328db92ac239d7

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4dd604f6e395951e54d2e4fa3c8bff559dafcfc3&selectedTaskRun=Du-_DUV7SNu5WWZn0en_uQ.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317589410&repo=autoland&lineNumber=3371

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/e29c5f0e349d

Comment 6

[Dragana Damjanovic [:dragana]]

(In reply to Cristian Brindusan [:cbrindusan] from comment #4)

Backed out changeset 4dd604f6e395 (bug 1667351) for causing high frequency xpcshell failures at test_altsvc_pref.js.
https://hg.mozilla.org/integration/autoland/rev/e29c5f0e349d9bd193f4076f81328db92ac239d7

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4dd604f6e395951e54d2e4fa3c8bff559dafcfc3&selectedTaskRun=Du-_DUV7SNu5WWZn0en_uQ.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317589410&repo=autoland&lineNumber=3371

The test failure is fixed by bug 1669449. This bug revealed an already existing bug in the code.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e003481e19ab
Process neqo events immediately after a cert authentication is done. r=necko-reviewers,valentin

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e003481e19ab