1667377 - waitForNavigationCompleted doesn't trigger callback when no load events are expected or page load strategy is None

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If there is a navigation to be observed by waitForNavigationCompleted the specified callback, which triggers the navigation, is actually never called when there are no page load events expected or the set page load strategy capability is None. Instead it just returns a resolved promise:

https://searchfox.org/mozilla-central/rev/89d33e1c3b0a57a9377b4815c2f4b58d933b7c32/testing/marionette/navigate.js#194-196

This is a regression from bug 1612831.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1667377 - [wdspec] Added test for WebDriver:ElementClick to open a link with target=_blank..

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1667377 - [marionette] Always call navigation callback in waitForNavigationCompleted.

Even in the case of no load event expected, or the page load strategy
as set to None the callback that triggers the navigation always has
to be called.

Depends on D91443

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4806d53c46a
[wdspec] Added test for WebDriver:ElementClick to open a link with target=_blank.. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/1d341cedbe03
[marionette] Always call navigation callback in waitForNavigationCompleted. r=marionette-reviewers,maja_zf

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25792 for changes under testing/web-platform/tests

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f4806d53c46a
https://hg.mozilla.org/mozilla-central/rev/1d341cedbe03

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9177906 [details]
Bug 1667377 - [marionette] Always call navigation callback in waitForNavigationCompleted.

Beta/Release Uplift Approval Request

• User impact if declined: Various WebDriver navigation commands do not actually trigger the page load when there are no page load events expected (like opening a link in a new tab or in a different frame), or the navigation shouldn't be awaited for.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds the call to trigger the navigation under any situation.
• String changes made/needed: no

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9177906 [details]
Bug 1667377 - [marionette] Always call navigation callback in waitForNavigationCompleted.

marionette fix, approved for 82.0b6

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a328a1cad63
https://hg.mozilla.org/releases/mozilla-beta/rev/87c3574ff598