1667385 - Warp: Transpile MGuardHasGetterSetter

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[André Bargull [:anba]]

Bug 1667037 shows that it could be helpful to transpile GuardHasGetterSetter. I haven't investigated how the numbers from bug 1667037 change after transpiling GuardHasGetterSetter, though. For example after transpiling GuardHasGetterSetter, other unsupported CacheIR ops could still prevent to Warp-compile the IC.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1667385 - Part 1: Change GuardHasGetterSetter to a shared CacheIR op. r=jandem!

The Baseline and Ion implementations didn't differentiate, so let's move them
to CacheIRCompiler.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1667385 - Part 2: Transpile GuardHasGetterSetter. r=jandem!

Transpile GuardHasGetterSetter to use an ABI-call, just like we do in the CacheIR
implementation.

Depends on D91429

Comment 3

[André Bargull [:anba]]

(In reply to André Bargull [:anba] from comment #0)

I haven't investigated how the numbers from bug 1667037 change after transpiling GuardHasGetterSetter, though.

I've tested the patch on youtube.com (499 of 802 GuardHasGetterSetter calls were on youtube) and the number of other non-transpilable CacheIR ops didn't surge, so this patch does this seem to help.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5dff52c4008
Part 1: Change GuardHasGetterSetter to a shared CacheIR op. r=jandem
https://hg.mozilla.org/integration/autoland/rev/7e0b73408fe8
Part 2: Transpile GuardHasGetterSetter. r=jandem

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b5dff52c4008
https://hg.mozilla.org/mozilla-central/rev/7e0b73408fe8