1667402 - The "Save to Pocket" doorhanger is wrongly dismissed after ~3 seconds if is not hovered/focused

Status: VERIFIED FIXED

(Firefox :: Pocket, enhancement, P2)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 83.0a1 - Build ID: 20200925094208

[Affected Platforms]:

• Windows 10 x64
• macOS 10.15
• Ubuntu 18.04 x64

[Prerequisites]:

• You are logged in to Pocket.
• Have the browser.search.region pref set to US in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and click any "Recommended by Pocket" card.
3. Click the "Save to Pocket" button from the right part of the "Address Bar".
4. Observe the behavior.

[Expected result]:

• The "Saved to Pocket" doorhanger is successfully opened.

[Actual result]:

• The "Saved to Pocket" doorhanger is successfully opened but is dismissed after ~3 seconds.

[Notes]:

• This issue is also reproducible through keyboard navigation even if the doorhanger is focused.
• The doorhanger is not dismissed if the doorhanger is focused or hovered.
• Considering the fact that the "Recommended Stories" were added to the "Saved to Pocket" doorhanger, a user might not have enough time to read them if the doorhanger is dismissed after a few seconds.
• Attached a screen recording of the issue.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

@Wolasi – This isn't a regression, but I agree we should increase the timer duration (3.5 seconds currently). What should we increase it to?

Comment 2

[Wolasi :wolasi]

:gvn let's try 4.5 seconds

Comment 3

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1667402 - Increase close timer

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 9179065 [details]
Bug 1667402 - Increase close timer

Beta/Release Uplift Approval Request

• User impact if declined: UI/UX improvements to a feature we are looking to pref on.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Log into Pocket.

2. Open a pocket story (easiest from newtab)
3. Click the save to Pocket button.
4. Wait.

Expected: should close the doorhanger with 4 and a half seconds.

It's not a lot, but it helps, and it's better than it was, giving the user a bit more time to interact. Also if you tab into it, in bug 1668247, it should stay open.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just an int change. One line.
• String changes made/needed: none

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad0f2bbfce3
Increase close timer r=thecount

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4ad0f2bbfce3

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9179065 [details]
Bug 1667402 - Increase close timer

approved for 82.0b7

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/322b7b2dac4b

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (82.0b7 Build ID - 20201002191150), and the latest Firefox Nightly (83.0a1 Build ID - 20201004212809) installed, on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15. Now, I can confirm that the "Pocket" doorhanger is dismissed after ~4 and a half seconds.