Closed Bug 1667461 Opened 4 years ago Closed 4 years ago

Add a note about class name collisions to a leak checking assertion

Categories

(Core :: XPCOM, task)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

Example failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312944925&repo=try&lineNumber=37654

I was hitting a leak checking assertion when I had two refcounted classes with the name AsyncReadbackBuffer in different namespaces. I fixed the assertion by including the namespace inside the NS_INLINE_DECL_THREADSAFE_REFCOUNTING macro.
I think it would be nice if the assertion message mentioned this failure case.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/683cb2775d4a
Add a note about class name collisions. r=nika,xpcom-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: