Some displayport-related cleanups
Categories
(Core :: Panning and Zooming, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(7 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1667475 - Consolidate displayport-related flags into a DisplayPortOptions struct. r=kats,tnikkel
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•4 years ago
|
||
The two existing uses were inconsistent in whether the margins
were relative to the visual viewport or the layout viewport.
We could fix this, but it turns out both uses are readily
refactored to not need the field, so this patch removes the
field.
Assignee | ||
Comment 2•4 years ago
|
||
It stopped being relative to mScrollOffset in bug 1519285, when that
patched change the value stored in mScrollOffset to be the visual
scroll offset even for the Layers copy of the metrics.
Depends on D91479
Assignee | ||
Comment 3•4 years ago
|
||
Adding leave-open keyword as there are more cleanups to come.
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/600c18995b01 Remove FrameMetrics::mDisplayPortMargins. r=kats https://hg.mozilla.org/integration/autoland/rev/dddcc84c41b2 Document that FrameMetrics::mDisplayPort is relative to GetLayoutScrollOffset(). r=kats
Comment 5•4 years ago
|
||
bugherder |
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
It looks like these are unused as of bug 1629466.
Depends on D92006
Assignee | ||
Comment 8•4 years ago
|
||
The only caller passed in DisplayRelativeTo::ScrollFrame.
Removing this makes it easier to consolidate display port options
in a subsequent patch.
Depends on D92013
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D92014
Assignee | ||
Comment 10•4 years ago
|
||
Depends on D92015
Assignee | ||
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76b8aecaab76 Moved displayport-related functions from nsLayoutUtils to a new DisplayPortUtils class. r=kats https://hg.mozilla.org/integration/autoland/rev/f841d162b2ad Remove no-longer-used 'aOutPainted' parameters. r=kats https://hg.mozilla.org/integration/autoland/rev/e9158f91bc3a Drop the 'aRelativeTo' parameter of GetDisplayPortForVisibilityTesting(). r=kats https://hg.mozilla.org/integration/autoland/rev/2c1a3257a08d Consolidate displayport-related flags into a DisplayPortOptions struct. r=kats https://hg.mozilla.org/integration/autoland/rev/ecfb6ab85b7a Move handling of DisplayportRelativeTo inside GetDisplayPortImpl(). r=kats
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/76b8aecaab76
https://hg.mozilla.org/mozilla-central/rev/f841d162b2ad
https://hg.mozilla.org/mozilla-central/rev/e9158f91bc3a
https://hg.mozilla.org/mozilla-central/rev/2c1a3257a08d
https://hg.mozilla.org/mozilla-central/rev/ecfb6ab85b7a
Description
•