1667475 - Some displayport-related cleanups

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Remove FrameMetrics::mDisplayPortMargins. r=kats

The two existing uses were inconsistent in whether the margins
were relative to the visual viewport or the layout viewport.

We could fix this, but it turns out both uses are readily
refactored to not need the field, so this patch removes the
field.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Document that FrameMetrics::mDisplayPort is relative to GetLayoutScrollOffset(). r=kats

It stopped being relative to mScrollOffset in bug 1519285, when that
patched change the value stored in mScrollOffset to be the visual
scroll offset even for the Layers copy of the metrics.

Depends on D91479

Comment 3

[Botond Ballo [:botond]]

Adding leave-open keyword as there are more cleanups to come.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/600c18995b01
Remove FrameMetrics::mDisplayPortMargins. r=kats
https://hg.mozilla.org/integration/autoland/rev/dddcc84c41b2
Document that FrameMetrics::mDisplayPort is relative to GetLayoutScrollOffset(). r=kats

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/600c18995b01
https://hg.mozilla.org/mozilla-central/rev/dddcc84c41b2

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Moved displayport-related functions from nsLayoutUtils to a new DisplayPortUtils class. r=kats,tnikkel

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Remove no-longer-used 'aOutPainted' parameters. r=kats,tnikkel

It looks like these are unused as of bug 1629466.

Depends on D92006

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Drop the 'aRelativeTo' parameter of GetDisplayPortForVisibilityTesting(). r=kats,tnikkel

The only caller passed in DisplayRelativeTo::ScrollFrame.

Removing this makes it easier to consolidate display port options
in a subsequent patch.

Depends on D92013

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Consolidate displayport-related flags into a DisplayPortOptions struct. r=kats,tnikkel

Depends on D92014

Comment 10

[Botond Ballo [:botond]]

Attachment: Bug 1667475 - Move handling of DisplayportRelativeTo inside GetDisplayPortImpl(). r=kats,tnikkel

Depends on D92015

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76b8aecaab76
Moved displayport-related functions from nsLayoutUtils to a new DisplayPortUtils class. r=kats
https://hg.mozilla.org/integration/autoland/rev/f841d162b2ad
Remove no-longer-used 'aOutPainted' parameters. r=kats
https://hg.mozilla.org/integration/autoland/rev/e9158f91bc3a
Drop the 'aRelativeTo' parameter of GetDisplayPortForVisibilityTesting(). r=kats
https://hg.mozilla.org/integration/autoland/rev/2c1a3257a08d
Consolidate displayport-related flags into a DisplayPortOptions struct. r=kats
https://hg.mozilla.org/integration/autoland/rev/ecfb6ab85b7a
Move handling of DisplayportRelativeTo inside GetDisplayPortImpl(). r=kats

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/76b8aecaab76
https://hg.mozilla.org/mozilla-central/rev/f841d162b2ad
https://hg.mozilla.org/mozilla-central/rev/e9158f91bc3a
https://hg.mozilla.org/mozilla-central/rev/2c1a3257a08d
https://hg.mozilla.org/mozilla-central/rev/ecfb6ab85b7a