1667600 - View Image error on canvas

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Dmitry Butskoy (:buc)]

Attachment: seamonkey-2.53.4-view_media_canvas.patch

Clicking "View Image" on a Canvas (which probably the same time is a frame) produces an error:

Error: TypeError: Argument 1 is not valid for any of the 1-argument overloads of URL.createObjectURL.
Source File: chrome://communicator/content/nsContextMenu.js
Line: 1127

The problem is
let blobUrl = URL.createObjectURL(this.target);
because this.target.toBlob() must be used rather then just this.target .
(And toBlob() canvas method is async).

Note, the correspond Fx part has toBlob()

Preliminary patch attached (fixed the issue).

Comment 1

[Dmitry Butskoy (:buc)]

Was introduced by the patch from the bug #1234651

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1667600-view_media_canvas-257.patch

Reformatted as hg patch for checkin and using arrow function. Tested with 2.53.5.
r/a+ from me. Thanks++

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1f2a0bfff8d
Use toBlob for viewing media files on a canvas. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2793cb15a67ff51636e342d355d71a1c73cedf7d