1667615 - Fold GlobalHelperThreadState::finishModuleParseTask into finishSingleParseTask

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

The finishModuleParseTask relies on the global js::UseOffThreadParseGlobal method instead of checking CompileOptions of the task. This makes it harder to mix stencil and script XDR modes in the browser.

If we combine the finishModuleParseTask with finishSingleParseTask which still has access to the task, we can check options instead.

Additionally, the module->fixEnvironmentsAfterRealmMerge(); code can probably go into the mergeRealms block https://searchfox.org/mozilla-central/rev/0eebca3c33b7999bfd090672e6c6dde96ae89616/js/src/vm/HelperThreads.cpp#1884-1911

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667615 - Move module handling from GlobalHelperThreadState::finishModuleParseTask to GlobalHelperThreadState::finishSingleParseTask. r?tcampbell!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0392a47a8f4
Move module handling from GlobalHelperThreadState::finishModuleParseTask to GlobalHelperThreadState::finishSingleParseTask. r=tcampbell

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a0392a47a8f4