Columns in header context menu for WS/SSE should be listed in correct order
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox83 fixed)
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: andrewaclt, Assigned: rockingskier)
Details
Attachments
(3 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0
Steps to reproduce:
- Send some websocket data
- Click Hamburger Menu -> Web Developer -> Network
- Filter the network traffic to "WS"
- Select the websocket request you want to see the control frames of
- Click Response
- Click the All dropdown (beside the trashcan) and also select "Control"
- Under the All (Control) dropdown, right click data and check opcodes (or other fields)
- Notice that the column headers are not correct (see screenshot)
Actual results:
The columns do not match up with their data.
Expected results:
Under the Opcode column you should see the correct opcode. Under the time column you should see the correct time. The column and column data are swapped.
Comment 1•5 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
I'm happy to tackle this.
The headers take their ordering from the MESSAGE_HEADERS array.
The data columns and context menu get their ordering from the columns state object by doing Object.entries(columns)
.
All of these places need to use the same ordering logic. I'd be inclined to take the ordering from MESSAGE_HEADERS
as arrays are generally better for defining order.
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
@rockingskier: I am reopening this since I just looked at your patch and there is one thing we should yet fix. The order of columns in the context menu should follow the column order in the list.
Can you please update your patch?
Thanks for helping with this!
Honza
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
My hg-fu is not great and I seem to have created a second patch again.
Anyway, the second patch is correct.
Updated•5 years ago
|
Comment 10•5 years ago
|
||
bugherder |
Description
•