Closed Bug 1667634 Opened 5 years ago Closed 5 years ago

Columns in header context menu for WS/SSE should be listed in correct order

Categories

(DevTools :: Netmonitor, defect, P3)

Firefox 81
defect

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: andrewaclt, Assigned: rockingskier)

Details

Attachments

(3 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

  1. Send some websocket data
  2. Click Hamburger Menu -> Web Developer -> Network
  3. Filter the network traffic to "WS"
  4. Select the websocket request you want to see the control frames of
  5. Click Response
  6. Click the All dropdown (beside the trashcan) and also select "Control"
  7. Under the All (Control) dropdown, right click data and check opcodes (or other fields)
  8. Notice that the column headers are not correct (see screenshot)

Actual results:

The columns do not match up with their data.

Expected results:

Under the Opcode column you should see the correct opcode. Under the time column you should see the correct time. The column and column data are swapped.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Inspector
Product: Firefox → DevTools
Component: Inspector → Netmonitor

I'm happy to tackle this.

The headers take their ordering from the MESSAGE_HEADERS array.
The data columns and context menu get their ordering from the columns state object by doing Object.entries(columns).

All of these places need to use the same ordering logic. I'd be inclined to take the ordering from MESSAGE_HEADERS as arrays are generally better for defining order.

Assignee: nobody → rockingskier

Thanks for the report!

This has been fixed in bug 1668985

Honza

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

@rockingskier: I am reopening this since I just looked at your patch and there is one thing we should yet fix. The order of columns in the context menu should follow the column order in the list.

Can you please update your patch?
Thanks for helping with this!

Honza

Severity: -- → S3
Status: RESOLVED → REOPENED
Ever confirmed: true
Flags: needinfo?(rockingskier)
Priority: -- → P3
Resolution: DUPLICATE → ---
Summary: Network Inspector websocket control frame data is not displayed In correct columns → Columns in header context menu for WS/SSE should be listed in correct order

My hg-fu is not great and I seem to have created a second patch again.

Anyway, the second patch is correct.

Flags: needinfo?(rockingskier) → needinfo?(odvarko)
Attachment #9180691 - Attachment is obsolete: true
Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e223ce61d1a2 Order WS message column context menu consistently. r=Honza
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: