1667648 - autocomplete with Lightning is wrong when comment column is enabled

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philippe VIGNEAU]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

set mail.autoComplete.commentColumn to 1
go to Lightning, create an event and try to add one attendee, the email autocompletion is wrong, you only see the address book name, not the emails...

Actual results:

Expected results:

see emails plus address book names (like in email autocompletion)

Comment 1

[WaltS48 [:walts48]]

In my 78.3.0 the default is "mail.autoComplete.commentColumn;0".

Does the CardBook extension change that to a "1", and why is it needed?

If I change it to a "1", and try to invite attendees, all I see now is address book names without the extension.

Comment 2

[Philippe VIGNEAU]

CardBook does not change the mail.autoComplete.commentColumn option.

I do not understand why setting this option to 1 is supported when writting email and why this is not supported for adding an attendee...

Comment 3

[Geoff Lankow (:darktrojan)]

I do not understand why setting this option to 1 is supported when writting email and why this is not supported for adding an attendee...

Perhaps it's because the developer has never come across this preference before.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1667648 - Copy auto-complete drop-down styles into event attendees dialog. r?Paenglab

We should figure out how to make this widget self-contained as Firefox does, but for now I just want to fix the bug with a simple patch that can be uplifted.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/860c58cae454
Copy auto-complete drop-down styles into event attendees dialog. r=Paenglab

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/31641628ab4e
follow-up - Fix bad CSS selector. rs=bustage-fix DONTBUILD

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9178137 [details]
Bug 1667648 - Copy auto-complete drop-down styles into event attendees dialog. r?Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1639763
User impact if declined: users with a pref set can't see the most important info in a dialog
Testing completed (on c-c, etc.): on c-c for a week
Risk to taking this patch (and alternatives if risky):

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9178137 [details]
Bug 1667648 - Copy auto-complete drop-down styles into event attendees dialog. r?Paenglab

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1953ded9253a
https://hg.mozilla.org/releases/comm-beta/rev/33c9be6b8d6a

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9178137 [details]
Bug 1667648 - Copy auto-complete drop-down styles into event attendees dialog. r?Paenglab

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/e6250641ad70
https://hg.mozilla.org/releases/comm-esr78/rev/096f4624d345