1667674 - [Wayland] Support public primary-selection unstable protocol

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Robert Mader [:rmader]]

Additionally to the functionally equal but private gtk-primary-selection protocol. This should allow middle click pasting to work on compositors like Kwin and will allow us to remove the private one eventually.

Support in gtk3 just landed (https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2627), which already allows copying from FF - but pasting into is handled by FF itself and thus needs adjustment.

Comment 1

[Robert Mader [:rmader]]

Attachment: Bug 1667674 - [Wayland] Support public primary-selection unstable protocol. r=stransky

This is required to support pasting the primary selection into Firefox on compositors only
supporting the public protocol, such as KWin. Getting the selection from Firefox is done
via GTK and will be supported from GTK 3.24.23 on.

The public protocol, while practically identical, will replace the gtk-private one eventually.
However, support for the private one will still be needed for a while.

Note: this also updates the auto-generated gtk-primary-selection files.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Cool! Will look at it ASAP.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/499103fc4ccb
[Wayland] Support public primary-selection unstable protocol. r=stransky

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_aboutCertError_offlineSupport.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/480b4aeecc2bfab12d2c5b86e21542e76c0ddb62
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317197378&repo=autoland&lineNumber=3099

Comment 5

[Robert Mader [:rmader]]

The error looks completely unrelated - please reland.

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backfill and retrigger points to this push.
Please check: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=YP0t5F14QO-c6_xvbyU2jw.0&resultStatus=success%2Ctestfailed%2Cbusted%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s%2Cbc3&fromchange=e0792656b720771d86304b57103e9a8673e4c331

Thank you

Comment 7

[Robert Mader [:rmader]]

This is really odd - the test doesn't even appear to exist (see https://searchfox.org/mozilla-central/search?q=browser_aboutCertError&path=) - sorry, this really looks like a temporary bug in the test infrastructure, not in this patch. Please retry after some time or after a rebase or so.

Comment 8

[Narcis Beleuzu [:NarcisB]]

The test was added today in Bug 1644719
Ill do some extra retriggs in few hours and if something changes, Ill re-land it

Comment 9

[Robert Mader [:rmader]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #8)

The test was added today in Bug 1644719
Ill do some extra retriggs in few hours and if something changes, Ill re-land it

Ah right. Looks like the test was backed out, so you could probably just reland and the test wouldn't be there any more :/ Anyhow, thanks for caring!

Comment 10

[Robert Mader [:rmader]]

As bug 1644719 was backed out, mind relanding this? :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c19f0bf1b11
[Wayland] Support public primary-selection unstable protocol. r=stransky

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5c19f0bf1b11

Comment 13

[Arksunix]

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Comment 15

[Arksunix]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

Comment 16

[Martin Stránský [:stransky] (ni? me)]

(In reply to Arksunix from comment #15)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

Yes but it's missing many important Wayland fixes. You can threat it as "tech preview" or so. ESR line gets only security fixes.

Comment 17

[Arksunix]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #16)

(In reply to Arksunix from comment #15)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

Yes but it's missing many important Wayland fixes. You can threat it as "tech preview" or so. ESR line gets only security fixes.

Thank you. Then I'll go try to build a sway with support for the old protocol.