Closed Bug 1667674 Opened 2 years ago Closed 2 years ago

[Wayland] Support public primary-selection unstable protocol

Categories

(Core :: Widget: Gtk, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: rmader, Assigned: rmader)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Additionally to the functionally equal but private gtk-primary-selection protocol. This should allow middle click pasting to work on compositors like Kwin and will allow us to remove the private one eventually.

Support in gtk3 just landed (https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2627), which already allows copying from FF - but pasting into is handled by FF itself and thus needs adjustment.

Assignee: nobody → robert.mader
Status: NEW → ASSIGNED

This is required to support pasting the primary selection into Firefox on compositors only
supporting the public protocol, such as KWin. Getting the selection from Firefox is done
via GTK and will be supported from GTK 3.24.23 on.

The public protocol, while practically identical, will replace the gtk-private one eventually.
However, support for the private one will still be needed for a while.

Note: this also updates the auto-generated gtk-primary-selection files.

Cool! Will look at it ASAP.

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/499103fc4ccb
[Wayland] Support public primary-selection unstable protocol. r=stransky

The error looks completely unrelated - please reland.

Flags: needinfo?(robert.mader)

This is really odd - the test doesn't even appear to exist (see https://searchfox.org/mozilla-central/search?q=browser_aboutCertError&path=) - sorry, this really looks like a temporary bug in the test infrastructure, not in this patch. Please retry after some time or after a rebase or so.

Flags: needinfo?(robert.mader)

The test was added today in Bug 1644719
Ill do some extra retriggs in few hours and if something changes, Ill re-land it

(In reply to Narcis Beleuzu [:NarcisB] from comment #8)

The test was added today in Bug 1644719
Ill do some extra retriggs in few hours and if something changes, Ill re-land it

Ah right. Looks like the test was backed out, so you could probably just reland and the test wouldn't be there any more :/ Anyhow, thanks for caring!

As bug 1644719 was backed out, mind relanding this? :)

Flags: needinfo?(nbeleuzu)
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c19f0bf1b11
[Wayland] Support public primary-selection unstable protocol. r=stransky
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Flags: needinfo?(nbeleuzu)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

(In reply to Arksunix from comment #15)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

Yes but it's missing many important Wayland fixes. You can threat it as "tech preview" or so. ESR line gets only security fixes.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #16)

(In reply to Arksunix from comment #15)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

(In reply to Arksunix from comment #13)

For the same reason, composers have started dropping support for gtk-primary-selection (e.g. wlroots). Is it possible to add this change to Firefox ESR to make PRIMARY selection work again?

Wayland backend is not supposed to work on ESR line yet.

Firefox ESR 78.10.0 with flag MOZ_ENABLE_WAYLAND=1 run on Wayland (without Xwayland)

Yes but it's missing many important Wayland fixes. You can threat it as "tech preview" or so. ESR line gets only security fixes.

Thank you. Then I'll go try to build a sway with support for the old protocol.

You need to log in before you can comment on or make changes to this bug.