Closed Bug 1667719 Opened 4 years ago Closed 4 years ago

Add preferences, warnings and telemetry for the scriptminsize and scriptsizemultiplier attributes

Categories

(Core :: MathML, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This is to prepare bug 1548471.

Note that the pref won't disable scriptminsize's default effect on cascade.rs's handle_mathml_scriptlevel_if_needed

Attachment #9178162 - Flags: data-review?(bmiroglio)

These attributes have been removed from MathML Core and their use case
could be handled by other ways:

  1. Rely on font.minimum-size.x-math and/or improve CSS math-depth to avoid
    that the font-size due to math-depth change becomes very small.
  2. Implement support for the OpenType MATH parameters to customize the
    scaling factor and/or improve math-depth to accept float values, so that
    people can customize the automatic scaling down.

This patch is a tentative to remove these attributes. They will be disabled
under a preference flag on nightly and have warning/telemetry on other
channels. Note that the effect of the default scriptminsize (8pt) is not
disabled from cascade.rs's handle_mathml_scriptlevel_if_needed yet. This
part will require more care (see bug 1548471).

Attachment #9178174 - Attachment description: Bug 1667719: Add preferences, warnings and telemetry for the scriptminsize and scriptsizemultiplier attributes → Bug 1667719: Add preferences, warnings and telemetry for the scriptminsize and scriptsizemultiplier attributes. r=emilio
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77d293ef9571
Add preferences, warnings and telemetry for the scriptminsize and scriptsizemultiplier attributes. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25817 for changes under testing/web-platform/tests
Attachment #9178162 - Flags: data-review?(bmiroglio) → data-review?(mmccorquodale)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Upstream PR merged by moz-wptsync-bot

Comment on attachment 9178162 [details]
request-scriptminsize-scriptsizemultiplier.txt

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, this will be documented in the probe dictionary.

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, users can opt out of telemetry collection.

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Not permanent data collection.

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Category 1, technical data.

  5. Is the data collection request for default-on or default-off?
    Default on.

  6. Does the instrumentation include the addition of any new identifiers?
    No new identifiers.

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes.

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Check in in 6 months.

  9. Does the data collection use a third-party collection tool?
    No.


data-review +

Attachment #9178162 - Flags: data-review?(mmccorquodale) → data-review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: