1667734 - Evaluate ignoring X11/GDK/glib error functions when generating the signature

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Gabriele Svelto [:gsvelto]]

This crash and this crash have identical signatures but different root causes. My first thought when filing them was adding some of the frames to the skip-list but now I'm wondering if we might want to ignore some of the frames entirely otherwise the signature would be comically long.

So I would do the following, add these functions to the irrelevant list:

• _g_log_abort
• g_log_writer_default
• g_log_structured_array
• g_log_structured_standard
• _gdk_x11_display_error_event
• gdk_x_error
• _XError
• handle_error

And add the following ones to the prefix list:

• handle_response

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do today.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Example crash reports:

• 09d0ef31-0e8a-4a03-ab14-9b9950200927
• 5ba66fb6-3740-4e54-9f98-d27380200928

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

There's also "handle_errorf" in some signatures:

9c7d78eb-3ba0-4c89-942f-527410200926 handle_errorf

Gabriele: Do you want "handle_errorf" to be skipped (irrelevant) or included (prefix)?

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #3)

There's also "handle_errorf" in some signatures:

9c7d78eb-3ba0-4c89-942f-527410200926 handle_errorf

Gabriele: Do you want "handle_errorf" to be skipped (irrelevant) or included (prefix)?

Included (prefix). I've looked it up on Google and it seems to be some kind of Windows internal function for handling floating-point errors. Given that it seems uncommon it's better not flag it as irrelevant or we might lose some interesting crashes.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ok. Making those changes gets us this:

app@socorro:/app$ socorro-cmd signature 09d0ef31-0e8a-4a03-ab14-9b9950200927 5ba66fb6-3740-4e54-9f98-d27380200928 9c7d78eb-3ba0-4c89-942f-527410200926
Crash id: 09d0ef31-0e8a-4a03-ab14-9b9950200927
Original: _g_log_abort | g_log_writer_default
New:      _XReply
Same?:    False

Crash id: 5ba66fb6-3740-4e54-9f98-d27380200928
Original: g_log_structured_array
New:      g_log_default_handler
Same?:    False

Crash id: 9c7d78eb-3ba0-4c89-942f-527410200926
Original: handle_errorf
New:      handle_errorf | logf_special_common
Same?:    False

Do we want to add anything else in this pass to the lists or are these signatures ok?

Comment 6

[Gabriele Svelto [:gsvelto]]

I think we're fine

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5584: bug 1667734: add frames to irrelevant and prefix lists

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5584: "bug 1667734: add frames to irrelevant and prefix lists" in d68657b.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Deployed to prod in bug #1668367 just now. Marking as FIXED.