1667740 - Use reference count for ScriptStencil.immutableScriptData

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

If we want to keep ScriptStencil after instantiation (for off-thread encoding, or cache), instantiation shouldn't steal ScriptStencil.immutableScriptData.

instantiation moves the field into js::RuntimeScriptData.isd_, and js::RuntimeScriptData already has reference count.
We could use js::RuntimeScriptData for ScriptStencil.immutableScriptData, or make it variant.

Comment 1

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d63a58ad2ebb947e4863f17318f4bd5aea038d3

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667740 - Part 1: Use RuntimeScriptData in ScriptStencil. r?tcampbell!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667740 - Part 2: Move RuntimeScriptData to vm/SharedStencil.h. r?tcampbell!

Depends on D91923

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667740 - Part 3: Rename RuntimeScriptData to SharedImmutableScriptData. r?tcampbell!

Depends on D91924

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667740 - Part 4: Move SharedImmutableScriptData XDR into StencilXDR class. r?tcampbell!

Depends on D91925

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ddf8c23278
Part 1: Use RuntimeScriptData in ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/232b437d7a36
Part 2: Move RuntimeScriptData to vm/SharedStencil.h. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e0e696f32022
Part 3: Rename RuntimeScriptData to SharedImmutableScriptData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8a73f3d643d4
Part 4: Move SharedImmutableScriptData XDR into StencilXDR class. r=tcampbell

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80ddf8c23278
https://hg.mozilla.org/mozilla-central/rev/232b437d7a36
https://hg.mozilla.org/mozilla-central/rev/e0e696f32022
https://hg.mozilla.org/mozilla-central/rev/8a73f3d643d4

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing Bug 1668489.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=8a73f3d643d45b5022d63cba2279710335d3202d&searchStr=hazard

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=317255015&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=317257686&repo=mozilla-central

Backout link: https://hg.mozilla.org/integration/autoland/rev/2224900e3db5d978e2b2207336a6cfa412595ded

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e3005ef440a
Part 1: Use RuntimeScriptData in ScriptStencil. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/330a87688dff
Part 2: Move RuntimeScriptData to vm/SharedStencil.h. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/873b133c7f62
Part 3: Rename RuntimeScriptData to SharedImmutableScriptData. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/249ddc3a4e92
Part 4: Move SharedImmutableScriptData XDR into StencilXDR class. r=tcampbell

Comment 10

[Cosmin Sabou [:CosminS]]

Relanded this cause the backout didn't solve anything: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Jd7hyjiQQH2l0nVED1UaFg.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=2224900e3db5d978e2b2207336a6cfa412595ded&searchStr=linux%2Cx64%2Cdebug%2Cspidermonkey%2Cbuilds%2Chazard-linux64-shell-haz%2Fdebug%2Ch

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5e3005ef440a
https://hg.mozilla.org/mozilla-central/rev/330a87688dff
https://hg.mozilla.org/mozilla-central/rev/873b133c7f62
https://hg.mozilla.org/mozilla-central/rev/249ddc3a4e92