1667743 - Clean up unused esni code

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Kershaw Chang [:kershaw]]

After bug 1652677 landed, the old esni code is not used anymore. We should remove it.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1667743 - Remove unused esni code

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b7c8f6349b1
Remove unused esni code r=necko-reviewers,valentin

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0b7c8f6349b1

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out on request from kershaw for causing Bug 1667801:

https://hg.mozilla.org/integration/autoland/rev/b25155229d25cc476357485eddc202c2656566c9

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/b25155229d25

Comment 6

[Kershaw Chang [:kershaw]]

We've decided to support ESNI and ECH, so this bug is WONTFIX.

Comment 7

[Kershaw Chang [:kershaw]]

We've decided to replace ESNI with ECH entirely, so reopen this bug.

Comment 8

[Kershaw Chang [:kershaw]]

Attachment: Bug 1667743 - Remove unused esni code

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/117da9de7f66
Remove unused esni code r=necko-reviewers,dragana

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 117da9de7f66 (bug 1667743) for handshakeSucceeded related bustage.

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=18733ce7c875dc334b17e7c8f4289b4528a6dc75&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2Cbb&selectedTaskRun=bjxQujW9QxCplxprN6Ao6w.0&tochange=2c61fdd0277b7ebb43c25258b92397308bbfdcca

Backout link: https://hg.mozilla.org/integration/autoland/rev/abd48130f3509c2aa8eceb512fc09c50178e21db

Failure log: https://treeherder.mozilla.org/logviewer?job_id=323387580&repo=autoland&lineNumber=87582

[task 2020-12-03T01:25:15.957Z] 01:25:15     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2020-12-03T01:25:15.960Z] 01:25:15     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o Unified_cpp_protocol_http3.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/extensions/auth -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/cookie -I/builds/worker/checkouts/gecko/netwerk/dns -I/builds/worker/checkouts/gecko/netwerk/ipc -I/builds/worker/checkouts/gecko/netwerk/socket/neqo_glue -I/builds/worker/checkouts/gecko/netwerk/url-classifier -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Wno-psabi -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_protocol_http3.o.pp   Unified_cpp_protocol_http3.cpp
[task 2020-12-03T01:25:15.960Z] 01:25:15     INFO -  In file included from Unified_cpp_protocol_http3.cpp:119:0:
[task 2020-12-03T01:25:15.961Z] 01:25:15     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpConnection.cpp: In member function 'bool mozilla::net::nsHttpConnection::EnsureNPNComplete(nsresult&, uint32_t&)':
[task 2020-12-03T01:25:15.962Z] 01:25:15    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpConnection.cpp:442:8: error: variable 'handshakeSucceeded' set but not used [-Werror=unused-but-set-variable]
[task 2020-12-03T01:25:15.962Z] 01:25:15     INFO -     bool handshakeSucceeded = false;
[task 2020-12-03T01:25:15.963Z] 01:25:15     INFO -          ^~~~~~~~~~~~~~~~~~
[task 2020-12-03T01:25:15.966Z] 01:25:15     INFO -  cc1plus: all warnings being treated as errors
[task 2020-12-03T01:25:15.967Z] 01:25:15     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:674: recipe for target 'Unified_cpp_protocol_http3.o' failed
[task 2020-12-03T01:25:15.970Z] 01:25:15    ERROR -  make[4]: *** [Unified_cpp_protocol_http3.o] Error 1
[task 2020-12-03T01:25:15.970Z] 01:25:15     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2020-12-03T01:25:15.970Z] 01:25:15     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 11

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/jobs?repo=try&revision=35289bd13ef8604fb36279ba984209221d1d9153&selectedTaskRun=NrP5oWMvSrmbe3gK2xvvZg.0

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86c457d100fd
Remove unused esni code r=necko-reviewers,dragana

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/86c457d100fd

Comment 14

[raj.azharuddin]

As per cloudflare article ech is not yet fully ready and they will support esni till ech is ready so why remove esni feature from Firefox??

Comment 15

[Diego Casorran [:diegocr]]

Just upgraded to 85 and found this quite sudden and unfortunate as well, i can no longer connect to sites i used to be able to thanks to SNI.