Closed
Bug 1667753
Opened 4 years ago
Closed 4 years ago
Create distinct RawInt32 type for stub fields
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: anba, Assigned: jandem)
Details
Attachments
(2 files)
RawWord is currently used for signed int32 values, but it'd be clearer to have a separate RawInt32. That way RawWord is only used for unsigned word-sized values and the new RawInt32 can be used for signed int32 values.
See bug 1666736.
|
||
Updated•4 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Comment 1•4 years ago
|
||
RawPointer stub fields correspond to RawPointerField in YAML. It's treated the
same as RawWord but uses loadPtr/movePtr instead of load32/move32.
|
||
Updated•4 years ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
emitLoadStubField and emitLoadStubFieldConstant use move32/load32 for this type
so RawInt32 is more appropriate than RawWord.
Depends on D92601
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/710804c16a5b part 1 - Add RawPointer stub field type. r=anba https://hg.mozilla.org/integration/autoland/rev/0b3807576441 part 2 - Rename RawWord field type to RawInt32. r=anba
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/710804c16a5b
https://hg.mozilla.org/mozilla-central/rev/0b3807576441
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•