1667805 - Tab sound indicator overlaps the previous tab when play video in PiP player

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

Attachment: screenshot

If favicon is not provided, tab sound indicator overlaps the previous tab.

STR:

1. Play local mp4 video
2. View the video in PiP player

Actual results:
Tab sound indicator overlaps the previous tab
See attached screenshot.

Expected Results:
Tab sound indicator should not overlap the previous tab

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Ooof, looks like we missed a nasty case here (no favicon). Perhaps we can How should the speaker be positioned in this case, emanuela? Perhaps we can show the "world" default icon in the event that PiP is enabled like we do when we're pinned?

Comment 2

[emanuela [ux]]

Great idea, Mike. Let's use the default icon

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Do you have time to look at this one, Niklas?

Comment 4

[Niklas Baumgardner]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

Do you have time to look at this one, Niklas?

Yes, I can work on this

Comment 5

[Niklas Baumgardner]

Attachment: Bug 1667805 - Adding default favicon to tabs that don't have favicon when using PiP. ?mconley,Gijs

Depends on D90813

Comment 6

[Niklas Baumgardner]

Attachment: Bug 1667805 - Adding default favicon to tabs that don't have favicon when using PiP. r?mconley,Gijs

Depends on D90813

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0549adf92eb
Adding default favicon to tabs that don't have favicon when using PiP. r=Gijs

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c0549adf92eb

Comment 9

[:Gijs (he/him)]

Alice, could you confirm if this is fixed on today's nightly? Thank you!

Comment 10

[Alice0775 White]

(In reply to :Gijs (he/him) from comment #9)

Alice, could you confirm if this is fixed on today's nightly? Thank you!
Yes, this was fixed.
I can no longer reproduce the issue on Nightly83.0a1(20200929094055).

Comment 11

[:Gijs (he/him)]

Thank you!