1667875 - Color management performance regression with qcms rust rewrite

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

On all platforms we can see a significant image decoding performance regression when color management is in use, e.g.:

With color management: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,2239827,1,6&selected=2239827,1228693230
Without color management: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,2239829,1,6&selected=2239829,1228693232

Push log for the regression is

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a5cdfde00f159276453541049a8cbb5f7043ae2a&tochange=fa0bf905d4cb944368ddf8fbe38cca4107692fd4

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

For reference the treeherder targets supported AVX back when I added AVX variations. I assume that is still true today.

I forgot I added QCMS specific perf tests:

"C" implementation: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,2239825,1,6&selected=2239825,1228693228
"Platform" / e.g. AVX: https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,2239826,1,6&selected=2239826,1228693229

Looks like the performance actually improved slightly for the variant without intrinsics.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I think I know what this is.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

https://treeherder.mozilla.org/perf.html#/alerts?id=27015&hideDwnToInv=0

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1667875. Make sure that we enable the instruction set that we're using.

Without this the intrinsics end up as calls instead of inline

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30dd66b90e20
Make sure that we enable the instruction set that we're using. r=aosmond

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/30dd66b90e20

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1666057