1667887 - Remove dead code in highContrastCheck in the screenshots UI

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P3)

Description

[Emma Malysz]

https://searchfox.org/mozilla-central/rev/f27594d62e7f1d57626889255ce6a3071d67209f/browser/extensions/screenshots/selector/ui.js#61-63 is dead code because we respect background-image: url() and backplate over it now. This can be removed.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Well, in particular, it depends on browser.display.permit_backplate. But looking at how it's used here, depending on the contrast it could ideally just use @media (prefers-contrast: forced)...

Comment 2

[Falguni Islam]

Hello I got accepted as an outreachy applicant, Can I work on this bug?

Comment 3

[Falguni Islam]

Attachment: Bug 1667887 - Remove dead code in highContrastCheck in the screenshots UI.

Removing the unused javascript code.

Comment 4

[Falguni Islam]

Attachment: Bug 1667887: fixed remove dead code in highContrastCheck in the screenshots UI

Comment 5

[Falguni Islam]

Attachment: Bug 1667887: fix Remove Dead Code in HighContrastCheck in the Screenshots UI

Comment 6

[Dhanesh]

Hi.. i would like to take up this issue , if its unassigned . Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c18e36c5e1e
fix Remove Dead Code in HighContrastCheck in the Screenshots UI r=emalysz

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0c18e36c5e1e