Closed
Bug 1667911
Opened 4 years ago
Closed 4 years ago
Document::ResolveWithBaseURI() should return a NonNull
Categories
(Firefox :: Untriaged, enhancement)
Firefox
Untriaged
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: marcos, Assigned: saschanaz)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15
Steps to reproduce:
Document::ResolveWithBaseURI() currently returns Result<nsCOMPtr<nsIURI>, nsresult>, but it is assured to always return a non null value (or an error in the nsresult). As such, we should consider changing it to use NonNull<>.
|
Assignee | |
Comment 1•4 years ago
|
||
Looking at https://searchfox.org/mozilla-central/rev/f27594d62e7f1d57626889255ce6a3071d67209f/dom/bindings/BindingDeclarations.h#250, it seems its only for JS objects 🤔
|
|
Assignee | |
Comment 2•4 years ago
|
||
Ah okay, Emilio said we can use OwningNonNull 👍
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → krosylight
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca8efa3b5ada Return OwningNonNull from ResolveWithBaseURI() r=emilio
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•