1667918 - Remove clipped_world_rect from PrimitiveVisibility

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Glenn Watson [:gw]]

Calculating this for every primitive on every frame is expensive. In all cases where it is currently used, we can replace it by an equivalent or better calculation, removing the need to build this.

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1667918 - Pt 1 - Refactor compute_conservative_visibility.

Remove need for per-prim clipped_world_rect in calculate of
conservative visible rects for tiled primitives.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1667918 - Pt 2 - Remove world_clipped_rect from clip task bounds.

Clip task bounds already create a world space rect from the input
local / picture clip chain rect. So we can achieve the same result
by intersecting that with the current world clip rect.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea039548c24
Pt 1 - Refactor compute_conservative_visibility. r=nical
https://hg.mozilla.org/integration/autoland/rev/5a073f033b4d
Pt 2 - Remove world_clipped_rect from clip task bounds. r=nical

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9ea039548c24
https://hg.mozilla.org/mozilla-central/rev/5a073f033b4d

Comment 5

[Glenn Watson [:gw]]

Attachment: Bug 1667918 - Remove clipped_world_rect use from pictures with surfaces.

Instead of relying on the per-primitive calculated rect, add a path
that specifically determines this for pictures with surfaces. This
leaves only one place that relies on the per-primitive value, which
will be removed in the next patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0b89858f9a
Remove clipped_world_rect use from pictures with surfaces. r=nical

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6f0b89858f9a

Comment 8

[Glenn Watson [:gw]]

Attachment: Bug 1667918 - Pt 4 - Remove clipped_world_rect from primitive vis.

This patch removes the last use of clipped_world_rect, and removes
it from the PrimitiveVisibility struct.

Instead, the already calculated tile rect is used for visibility
determination when picture caching is enabled. When picture caching
is disabled, the clipped world rect is calculated on demand but
not stored.

This patch also introduces an enum for current visibility state,
which gives better control over accessing visibility information
depending on the current pass of frame building.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a7cd312e533
Pt 4 - Remove clipped_world_rect from primitive vis. r=nical

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5a7cd312e533

Comment 11

[Glenn Watson [:gw]]

This is complete now.