Open Bug 1667929 Opened 5 years ago Updated 1 month ago

Select[multiple][size="1"] shows scrollbars bigger than the select on Windows 10

Categories

(Firefox :: Theme, defect)

Unspecified
Windows 10
defect

Tracking

()

REOPENED

People

(Reporter: danny0838, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(7 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Create a tag <select multiple size=1>.

Actual results:

The controller (up and down arrows) is rendered badly. It spans two rows, and the down arrow is not clickable.

Expected results:

The controller (up and down arrows) should span one row with up and down arrow taking half height, and both arrows should be clickable.

Comment on attachment 9178387 [details]
Controller for select[multiple][size=1] in Firefox 52 (no up and down arrow)

For reference: in Firefox 52 there is no controller spanning two rows, but just no clickable controller.

Comment on attachment 9178387 [details] Controller for select[multiple][size=1] in Firefox 52 (no up and down arrow) For reference: in Firefox 52 there is no controller spanning two rows, but just no clickable controller.
Component: Untriaged → Layout: Form Controls
Product: Firefox → Core

Thank you for reporting this bug!

Testcase:

data:text/html,<select multiple size="1"><option>Volvo</option><option>Audi</option></select>

Using mozregression on Windows yields this range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f9356df325cd5df64ef952636b788db27fbfd19f&tochange=5d4199425f57cf5657ace9e868924164286e0f43

It seems Bug 1634109 is the only bug in the range related to <select> and scrollbar. Emilio, any ideas?

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(emilio)

Nah, that only affects dropdown selects. Bug 1365806 is the actual culprit here.

Regressed by: 1365806
Has Regression Range: --- → yes

This is a Windows theme issue, where we don't allow painting scroll arrows smaller than a certain size. Before bug 1365806 we'd suppress the scrollbars if they didn't fit, but that's not great (specially on OSes where the minimum scrollbar size is big).

The windows theme should probably not claim to have a minimum size and allow painting smaller scroll arrows. This works for me on Linux already with the non-native theme disabled (widget.disable-native-theme-for-content). Do you know if with that pref flipped on Windows the test-case behaves a bit better?

Component: Layout: Form Controls → Widget: Win32
Flags: needinfo?(emilio)
Summary: Select[multiple][size="1"] shows bad controller → Select[multiple][size="1"] shows scrollbars bigger than the select on Windows

For the testcase in comment 7, flipping widget.disable-native-theme-for-content=true on Windows 10 shrinks the scroll arrows a bit, but not much.

Isn't there any way to workaround this? Other browsers just don't have this issue even on Windows...

On Firefox 140 on Windows the arrows now look fine to me - they're contained inside the select widget.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

(In reply to Greg Stoll :gstoll from comment #11)

On Firefox 140 on Windows the arrows now look fine to me - they're contained inside the select widget.

This is not true. Issue still persists on Firefox 140.0.4 (Windows 10) with following source code:

<!DOCTYPE html>
<select multiple size=1>
<option>value 1</option>
<option>value 2</option>
<option>value 3</option>
</select>
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached image hover on Windows 11

Ah, sorry. On Windows 11 it looks correct to me (this is what it looks like when I hover over it)

OS: Unspecified → Windows 10
Summary: Select[multiple][size="1"] shows scrollbars bigger than the select on Windows → Select[multiple][size="1"] shows scrollbars bigger than the select on Windows 10
Component: Widget: Win32 → Theme
Product: Core → Firefox
Version: Firefox 81 → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: