1667954 - 2.04 - 2.75% Base Content JS / JS (linux1804-64-shippable, macosx1014-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push 755b9a0117fcca4f8ff79531378616fd57e800a5 (Fri September 25 2020)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a awsy performance regression from push 755b9a0117fcca4f8ff79531378616fd57e800a5. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

3% Base Content JS linux1804-64-shippable opt 2,895,001.33 -> 2,974,565.33
3% Base Content JS macosx1014-64-shippable opt 2,894,361.33 -> 2,973,452.00
3% JS macosx1014-64-shippable opt tp6 172,470,418.29 -> 176,921,703.10
2% Base Content JS linux1804-64-shippable opt 2,902,028.67 -> 2,973,843.33
2% Base Content JS windows7-32-shippable opt 2,299,675.60 -> 2,347,796.00
2% Base Content JS windows10-64-shippable-qr opt 2,919,566.00 -> 2,979,162.00

Improvements:

7% Images windows7-32-shippable opt tp6 8,481,917.28 -> 7,878,457.15

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Tooru Fujisawa [:arai]]

What's the meaning of those numbers (2,974,565.33 etc) ?

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

bytes.

Comment 3

[Tooru Fujisawa [:arai]]

thanks. I spotted the bug.
will post the patch shortly

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1667954 - Call setAllowRelazify for delazification. r?tcampbell!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d286def58a48
Call setAllowRelazify for delazification. r=tcampbell

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d286def58a48

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1665612

Comment 8

[Florin Strugariu [:Bebe]]

== Change summary for alert #27106 (as of Wed, 30 Sep 2020 21:38:05 GMT) ==

Improvements:

3% Base Content JS windows7-32-shippable opt 2,345,362.67 -> 2,277,848.00
3% Base Content JS linux1804-64-shippable opt 2,972,163.33 -> 2,896,404.00
3% Base Content JS linux1804-64-shippable-qr opt 2,971,816.67 -> 2,895,887.33
3% Base Content JS windows10-64-shippable opt 2,967,550.67 -> 2,891,949.33
3% Base Content JS macosx1014-64-shippable opt 2,971,222.67 -> 2,895,901.33
3% Base Content JS windows10-64-shippable-qr opt 2,976,727.33 -> 2,901,464.67
2% JS macosx1014-64-shippable opt tp6 176,567,385.11 -> 172,309,106.64
2% JS linux1804-64-shippable-qr opt tp6 174,715,205.63 -> 170,595,157.12
2% JS linux1804-64-shippable opt tp6 174,730,614.69 -> 171,012,778.81

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=27106