1667957 - Provide functions that convert an integer to a decimal nsAutoTString

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

There are several places in the code where a string representation of an integer is needed, either as a standalone or for concatenating. Such code could be simplified if we had functions converting to a string rather than needing to construct an empty string, and then append to it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

nsPrintfCString("%d", integer)?

Comment 2

[Simon Giesecke [:sg] [he/him]]

Well, yes. but isn't a nsPrintfCString much less efficient?

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1667957 - Provide functions that convert an integer to a decimal nsAutoTString. r=#xpcom-reviewers

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1667957 - Use new IntTo(C)String functions in dom/quota and its clients. r=#dom-workers-and-storage

Depends on D91716

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b9081a6e594
Provide functions that convert an integer to a decimal nsAutoTString. r=xpcom-reviewers,nika

Comment 6

[Atila Butkovits]

Backed outfor causing bustage on nsString.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b5baa3a5c6cdb65fcf05daa269e6a5476ff4fff0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=dQhYI1XaQzaLxXeVxgNoBQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=6b9081a6e59474ddf7670bc5dc665db0819e0fdd&searchStr=build

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317774678&repo=autoland&lineNumber=39213

Comment 7

[Simon Giesecke [:sg] [he/him]]

I have a fix. The new functions need to be moved over to nsString.h to avoid a include dependency cycle.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec9d975f5bc3
Provide functions that convert an integer to a decimal nsAutoTString. r=xpcom-reviewers,nika

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ec9d975f5bc3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9c57fe43df1
Use new IntTo(C)String functions in dom/quota and its clients. r=dom-workers-and-storage-reviewers,ttung

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b9c57fe43df1