Closed Bug 1667972 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 25834 - [COOP] access reporting: fix flakes reporting.html

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25834 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25834
Details from upstream follow.

b'arthursonzogni <arthursonzogni@chromium.org>' wrote:

[COOP] access reporting: fix flakes reporting.html

The WPT testharness.js is defining:

WindowTestEnvironment.prototype._forEach_windows = function(callback) {
// Iterate over the windows [self ... top, opener]. The callback is
// passed two objects, the first one is the window object itself, the
// second one is a boolean indicating whether or not it's on the same
// origin as the (...)

This causes some postMessage to be sent cross-window. They are reported
and causes failures. For instance in reporting-observer.html test.

This patch removes testharness.js from executor.html
This fixed the issue for reporting-observer.html

More generally, we shouldn't check access in between two windows, when
one of them is using testharness.js

Bug:1090273
Change-Id: I261b9bfece935e3613c250a3a9402a1c8a6ff14e

Reviewed-on: https://chromium-review.googlesource.com/2436742
WPT-Export-Revision: f469754f2e93c0549619f5e0eb15f9e645dcfee6

PR 25834 applied with additional changes from upstream: 2fef4d6f7ce1c5e0af3ed8421b2bc30eddb934f2, dbb8a3ff33b3cca0899018e7dee3989842017976
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b48067744f81 [wpt PR 25834] - [COOP] access reporting: fix flakes reporting.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/406366f5b60b [wpt PR 25834] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87d8781d3dd3 [wpt PR 25834] - [COOP] access reporting: fix flakes reporting.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/12b008e404ff [wpt PR 25834] - Update wpt metadata, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7a6633c3d21 [wpt PR 25834] - [COOP] access reporting: fix flakes reporting.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/d93b8a738cc5 [wpt PR 25834] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/f7a6633c3d21
https://hg.mozilla.org/mozilla-central/rev/d93b8a738cc5

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.