1667973 - Add a sandbox for evaluating js scripts embedded in PDFs

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Comment 1

[Calixte Denizet (:calixte)]

Attachment: Bug 1667973 - Add a sandbox to evaluate js embedded in PDF

PDF files can embed some js code in order to validate, format, ... the data entered by a user in a PDF form.
So in order to safely execute this js code, we create a Cu.Sandbox with only what we need/want to expose to the scripts.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c8e776cbd29
Add a sandbox to evaluate js embedded in PDF r=bdahl,dveditz,robwu

Comment 3

[Atila Butkovits]

Backed out for causing failures on browser_all_files_referenced.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e657efb7e68f12c4206df442eb9cd65aee3d68f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VwGvoFvGQ1-HOzkGQ1rfQA.0&searchStr=linux%2C18.04%2Cx64%2Copt%2Cmochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc6&revision=8c8e776cbd29328079d7c76035aab1b0f5ef3c01

Failure log: https://treeherder.mozilla.org/logviewer?job_id=330488865&repo=autoland&lineNumber=2643

Comment 4

[Calixte Denizet (:calixte)]

I updated the patch to remove some js files from the whitelist in browser_all_files_referenced.js and made a try:
https://treeherder.mozilla.org/jobs?repo=try&revision=95a0392b151f07a7141381c30ff4d2321ef96d1d&selectedTaskRun=UJlWcXIvSrKjQqs3ROiNCw.0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a13e286152a8
Add a sandbox to evaluate js embedded in PDF r=bdahl,dveditz,robwu

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a13e286152a8