Closed Bug 1667975 Opened 4 years ago Closed 4 years ago

Don't check rcode before parsing packet

Categories

(Core :: Networking: DNS, defect, P1)

Product:
Core
Component:
Networking: DNS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

Bug 1667975 - Don't check rcode before parsing packet r=#necko,dragana
47 bytes, text/x-phabricator-request
Details | Review

If we simply return NS_ERROR_FAILURE/NS_ERROR_UNKNOWN_HOST on server error we don't get the chance to check for the extended error option.

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/36315d89f75b Don't check rcode before parsing packet r=dragana,necko-reviewers

https://hg.mozilla.org/mozilla-central/rev/36315d89f75b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: