1668012 - Keyboard navigating one-off buttons after typing doesn't update the engine chiclet

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak]]

1. CTRL+L
   1a. [optional] type something
2. ALT+DOWN
3. type something more
4. cycle through one-off buttons with ALT+DOWN
   => The chiclet keeps showing the original engine instead of updating to the currently selected one.

Comment 1

[Harry Twyford]

This implementation was intentional. My thinking was that once the user in is "full" search mode, it would be confusing to preview other search modes. Let's run this by UX today.

Comment 2

[Marco Bonardo [:mak]]

It doesn't seem correct, navigating one-off buttons should show search mode preview like usual, imo.

Comment 3

[Marco Bonardo [:mak]]

Also, once I confirm the heuristic, we don't execute the original search mode action.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1668012 - Keyboard navigating one-off buttons after typing doesn't update the engine chiclet. r=harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a853a9d96612
Keyboard navigating one-off buttons after typing doesn't update the engine chiclet. r=harry

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset a853a9d96612 (bug 1668012) for Browser-chrome failures in newtab/test/browser/browser_topsites_section.js. CLOSED TREE#

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317305864&repo=autoland&lineNumber=2529

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=a853a9d96612efce53b7b57a816d8414af5d3057

Backout:
https://hg.mozilla.org/integration/autoland/rev/789bdf565d6ad7467ae2f0be8c695aae825271aa

Comment 7

[Marco Bonardo [:mak]]

conflict with another autoland patch.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3e34680e841
Keyboard navigating one-off buttons after typing doesn't update the engine chiclet. r=harry

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a3e34680e841