Closed Bug 1668029 Opened 4 years ago Closed 4 years ago

Amazon overlays a transparent link on top of image, causing it to display invisible in high contrast mode

Categories

(Core :: Layout, defect)

Firefox 81
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: msradel, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Attached image FF HC - Amazon.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

https://www.amazon.com/stores/Bose/page/9E24AFD5-B420-4859-BD2F-A993BA579B20

See related Bug 1666059 - Plex overlays a transparent button on top of text, causing invisible text in high contrast mode

Actual results:

See screen shots.

FIle name Schema - FF = Firefox, IE = Internet Explorer, HC = Hight Contrast Mode

  1. Firefox with High Contrast Mode
  2. Firefox without High Contrast Mode
  3. IE with High Contrast Mode

Expected results:

I should be able to view ALL images on the page.

Attached image FF - Amazon.jpg
Attached image IE HC - Amazon.jpg
Flags: needinfo?(emilio)
Attached file testcase

So this is because they effectively have a semi-transparent, absolutely-positioned link overlaid on top of the image, and we make it fully opaque.

Flags: needinfo?(emilio)
Blocks: hcm
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Amazon overlays a transparent button on top of image, causing it to display invisible in high contrast mode → Amazon overlays a transparent link on top of image, causing it to display invisible in high contrast mode
Component: Untriaged → Layout
Product: Firefox → Core

So it seems clear we need to deal with transparency in HCM somehow, not just resetting all backgrounds to the default one as we've done historically.

https://drafts.csswg.org/css-color-adjust-1/#forced-colors-properties seems to suggest we should just respect the alpha value and set the other components to the default background. Does that seem sensible? I suspect we should really set them to the "reverted" background in some cases, to make stuff like bug 1625036 work with backplating...

Thoughts?

Flags: needinfo?(mreschenberg)
Flags: needinfo?(jteh)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

So it seems clear we need to deal with transparency in HCM somehow, not just resetting all backgrounds to the default one as we've done historically.

https://drafts.csswg.org/css-color-adjust-1/#forced-colors-properties seems to suggest we should just respect the alpha value and set the other components to the default background. Does that seem sensible? I suspect we should really set them to the "reverted" background in some cases, to make stuff like bug 1625036 work with backplating...

Thoughts?

Yeah, I agree with you. I saw the plex bug and was thinking the same thing.

Flags: needinfo?(mreschenberg)
Assignee: nobody → emilio

But discard it when backplating behind text, so that text is readable.

This should be uncontroversial... Dealing with widgets is a bit harder
so TBD.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1130dfcdbc4 When resetting background color for high contrast, preserve alpha channel appropriately. r=morgan
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaa908b5583c When resetting background color for high contrast, preserve alpha channel appropriately. r=morgan

Leaving this in (both of) your very capable hands. :) Thanks.

Flags: needinfo?(jteh)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Thank you all for the quick research and resolution. It will make a huge difference for me and other who use high contrast.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: