1668099 - Unified build bustages in dom/media/gtest relating to AnnexB and TimeUnit

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm doing some work in the media gtests and am noticing some issues with the unified build.

• AnnexB.h is missing various definitions depending on unified build boundaries.
• TestMediaDataEncoder.cpp ends up missing mozilla::media::TimeUnit depending on unified build boundaries.

I'm going to touch these up + reformat include lists to match the style guide as I go.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r?jolin

Fix up includes so AnnexB.h and TestMediaDataEncoder.cpp don't rely on unified
build order. Reformat include lists to match style guide. Rework #include guard
on AnnexB.h to reflect style guide.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac2a9e147400
Fix symbols that rely on unified build order in media gtests. r=jolin

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ac2a9e147400

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9178569 [details]
Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r?jolin

uplifting to beta and esr78 as a dependency of bug 1618529

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ebe12ede1c1

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/a851459ebef0