166821 - reports.cgi broken by recent schema changes

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Dave Miller [:justdave]]

reported to [e-mail]:

http://landfill.bugzilla.org/bugzilla-tip/reports.cgi?product=FoodReplicator&output=most_recently_doomed&links=1&banner=1

2002-10-05 14:50 GMT+2
Software error:

SELECT defaultmilestone FROM products WHERE product = 'FoodReplicator':
Unknown column 'product' in 'where clause' at globals.pl line 250.

Comment 1

[Gervase Markham [:gerv]]

I believe this is bbaetz' work...

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Bleh.

I'm not going to get to this for a while - it just needs to be using aproduct_id
instead...

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Fixes problem, and also removes hard-coded product names (which is another bug
somewhere.)

Gerv

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 98363 [details] [diff] [review]
Patch v.1

The bugs.product_id=products.id join needs to be in the query always, else you
get $numbugs*$numprocucts results. Teh distinct will filter them out, but it
will still suck perf-wise.

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Here you go... but there are other examples of that problem in this file too.

Gerv

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 98405 [details] [diff] [review]
Patch v.2

But thats OK, because you're rewriting this file :)

I don't suppose you can explain why the status whiteboard needs to be empty for
this query, can you? (Don't change it, I'm just curious...)

r=bbaetz x2

Comment 7

[Bradley Baetz (:bbaetz)]

-> gerv

Comment 8

[Gervase Markham [:gerv]]

> I don't suppose you can explain why the status whiteboard needs to be empty for
> this query, can you? (Don't change it, I'm just curious...)

Presumably it's to do with the bugs being "untouched" or something.

Fixed.

Checking in reports.cgi;
/cvsroot/mozilla/webtools/bugzilla/reports.cgi,v  <--  reports.cgi
new revision: 1.58; previous revision: 1.57
done

Gerv