Closed Bug 1668242 Opened 7 months ago Closed 6 months ago

Fix under-reporting of printing errors in telemetry

Categories

(Toolkit :: Printing, task, P1)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: jwatt, Assigned: emalysz, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v83][old-ui-])

Attachments

(1 file)

In PrintUtils._displayPrintingError we record print error telemetry for errors that occur in the platform code when trying to create and reflow the print/print preview document. As far as I can tell we do not have any equivalent code to report errors that occur in the frontend code, or specifically errors that occur when trying to gather printer capabilities in the frontend code. We therefore have no idea how common these are.

Assignee: nobody → emalysz

What calls are expected to return errors?

Would it be the unrwiteable margins [1] and printer support/settings [2]? These promises would reject I suppose?

Is there a list of errors we should be expecting?

[1] https://searchfox.org/mozilla-central/rev/dfd9c0f72f9765bd4a187444e0c1e19e8834a506/toolkit/components/printing/content/print.js#851
[2] https://searchfox.org/mozilla-central/rev/dfd9c0f72f9765bd4a187444e0c1e19e8834a506/toolkit/components/printing/content/print.js#884-888

Flags: needinfo?(jwatt)

We'll really need to audit the code to answer that question, but basically gathering printer information is unreliable at almost any point. So the nsIPrinterList interface and the other interfaces accessed via it could all potentially fail.

Flags: needinfo?(jwatt)
Flags: needinfo?(jwatt)

If at some point we find that the printing error rate is higher with the new UI than the old UI, in addition to the work being done in this bug, we should also be catching more printing errors due to the more robust code described in bug 1653340 comment 11.

Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e340b4d515fa
report printing errors in telemetry in the frontend r=mstriemer
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.