Closed Bug 1668261 Opened 5 years ago Closed 5 years ago

arm64 emulator does not compile with !DEBUG

Categories

(Core :: JavaScript Engine: JIT, defect, P2)

ARM64
Linux
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

Configuring with --disable-debug also disables JS_CACHE_SIMULATOR_ARM64, following which Simulator::ExecuteInstruction no longer compiles because it has code that should be under that ifdef but isn't.

The cache simulation must be guarded by the correct ifdef.

Also, two debug-only variables should be flagged as such.

Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8cee8448e4d2 ARM64 cache simulator must be under ifdef. r=bbouvier
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: