1668302 - Video fails to play properly with software fallback (Windows 10)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jim Mathies [:jimm]]

STR:

1. view this video on USA Today, press play
2. wait for the video scroller to start moving, then scroll up and down.

result: see screen shot

Content tearing displayed in the video frame and the video does not play back

Comment 1

[Jim Mathies [:jimm]]

Attachment: screen shot

Comment 2

[Jim Mathies [:jimm]]

Appears to impact any animation AFAICT. Gifs and video on reddit and cnn are also impacted.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I've seen this as well. Matt do you want to take a look?

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1668302 - Implement RenderTextureHostSWL for wrapper texture hosts. r?jrmuizel

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1668302 - Expose SWGL state to TextureFactoryIdentifier. r?jrmuizel

This is mostly preparing for the future state where we might have SWGL WR mixed with real hardware webrender, and want a way to lookup the state per-compositor.

Depends on D92008

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea6160902594
Implement RenderTextureHostSWL for wrapper texture hosts. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8434906c98c4
Expose SWGL state to TextureFactoryIdentifier. r=jrmuizel

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 2 changesets (bug 1668302) for swr reftest failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=XVM2OFtpRpGPN9Rijaz5sA.0&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Creftests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-reftest-swr-e10s%2C&fromchange=8434906c98c4ce5f67c6027b914fd4ae53cd8e46&tochange=7cecd07c5e2e53e495cf5dda766868a9145eb2e5

Backout link: https://hg.mozilla.org/integration/autoland/rev/7cecd07c5e2e53e495cf5dda766868a9145eb2e5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317279067&repo=autoland&lineNumber=11969

[task 2020-10-01T12:30:51.813Z] 12:30:51     INFO - REFTEST TEST-START | layout/reftests/bugs/961887-2.html == layout/reftests/bugs/961887-2-ref.html
[task 2020-10-01T12:30:51.813Z] 12:30:51     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/961887-2.html | 1745 / 2054 (84%)
[task 2020-10-01T12:30:51.884Z] 12:30:51     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/961887-2-ref.html | 1745 / 2054 (84%)
[task 2020-10-01T12:30:52.069Z] 12:30:52     INFO - REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/961887-2.html == layout/reftests/bugs/961887-2-ref.html | image comparison, max difference: 1, number of differing pixels: 22
[task 2020-10-01T12:30:52.069Z] 12:30:52     INFO - REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAA...
[task 2020-10-01T12:30:52.070Z] 12:30:52     INFO - REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAAN...
[task 2020-10-01T12:30:52.071Z] 12:30:52     INFO - REFTEST INFO | Saved log: START file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/961887-2.html
[task 2020-10-01T12:30:52.072Z] 12:30:52     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2020-10-01T12:30:52.072Z] 12:30:52     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2020-10-01T12:30:52.073Z] 12:30:52     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2020-10-01T12:30:52.073Z] 12:30:52     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2020-10-01T12:30:52.074Z] 12:30:52     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2020-10-01T12:30:52.074Z] 12:30:52     INFO - REFTEST INFO | Saved log: START file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/961887-2-ref.html
[task 2020-10-01T12:30:52.075Z] 12:30:52     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2020-10-01T12:30:52.076Z] 12:30:52     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2020-10-01T12:30:52.077Z] 12:30:52     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2020-10-01T12:30:52.077Z] 12:30:52     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2020-10-01T12:30:52.078Z] 12:30:52     INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2020-10-01T12:30:52.078Z] 12:30:52     INFO - REFTEST TEST-END | layout/reftests/bugs/961887-2.html == layout/reftests/bugs/961887-2-ref.html

Other failures:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317269828&repo=autoland&lineNumber=4565
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317269711&repo=autoland&lineNumber=4541

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5685c7cca810
Implement RenderTextureHostSWL for wrapper texture hosts. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8071036406a5
Expose SWGL state to TextureFactoryIdentifier. r=jrmuizel

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5685c7cca810
https://hg.mozilla.org/mozilla-central/rev/8071036406a5