1668307 - Two suggestions remain displayed in the Pocket doorhanger when clicking the greyed-out Save button after focusing the tags input field

Status: VERIFIED FIXED

(Firefox :: Pocket, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: issue rec.gif

[Affected versions]:

• Firefox Beta 82.0b5
• Firefox Nightly 83.0a1

[Affected platforms]:

• Windows 10 x64
• macOS 10.15
• Ubuntu 18.04 x64

[Prerequisites]:

• Have the Firefox browser installed.
• You are logged into your Pocket account.

[Steps to reproduce]:

1. Open the Firefox browser.
2. Navigate to the following link https://www.makeuseof.com/tag/get-more-out-of-pocket-with-these-6-tips-to-enhance-your-reading-experience/
3. Click the "Save to Pocket" button from the right part of the "Address Bar".
4. Click inside the tags field text.
5. Click the greyed-out “Save” button.
6. Observe the behavior.

[Expected result]:

• Nothing happens given that the “Save” button is greyed-out.

[Actual result]:

• Only 2 suggestions remain displayed in the doorhanger, the rest of the elements are removed.

[Notes]:

• Attached a screen recording of the behavior.

Comment 1

[Scott [:thecount] Downe]

I'm not able to reproduce, might have been fixed?

Comment 2

[Gavin Suntop [:gvn] (they/them)]

I can't repro in latest MC either. Appears to be resolved.

Comment 3

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

@Scott @Gavin

We tested this again on the latest Nightly build 83.0a1 (Build ID: 20201002092536) and the issue is still reproducible on our side.

Meanwhile we have found two other different scenarios that lead to the same incorrect behavior.

Scenario 1:

1. Click the "Save to Pocket" button from the right part of the "Address Bar".
2. Click the greyed-out “Save” button.
3. Press the “Tab” key several times.

Actual result:

• Only 2 suggestions remain displayed in the doorhanger, the rest of the elements are removed.

Scenario 2:

1. Copy a string using CTRL+C key shortcut.
2. Click the "Save to Pocket" button from the right part of the "Address Bar".
3. Paste the copied string from step 1 in the tags field using the CTRL+V keyboard shortcut.

Actual result:

• Only 2 suggestions remain displayed in the doorhanger, the rest of the elements are removed.

Could you both please try the steps above and report back the results? Thank you in advance.

Comment 4

[Scott [:thecount] Downe]

I figured it out, my pocket account has premium, up to this point I've been testing non premium by switching the pref extensions.pocket.settings.premium_status from 1 to 0, which tests most of the non premium functionality.

However, this bug above seems to be a bit more than that. You need a legit non premium pocket account to reproduce.

I'll see how hard this is to fix.

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1668307 - Remove code that changes the size of the pocket doorhanger for non premium users if you try to enter a tag

Comment 6

[Scott [:thecount] Downe]

I figured out what this was.

1. Because the contents of the door hanger are in an iframe currently, it means we need to manually set the height of the container if its contents change.
2. Logged in state, is premium, is there on save recs, is the tag dropdown open or not, all contribute to the complexity of the height of the container. In this case we're dealing with tag dropdown and is premium.
3. The tag dropdown while open would increase the container size, and decrease it when it closed. Didn't impact premium because there is already enough space so it knew to do nothing.
4. This was older code, and uses a plugin. The plugin's on dropdown close was firing incorrectly though, even if you interact with the input.

I think the solution for now is to actually just to remove the code that fired if the dropdown closes. It just means the container stays a little bigger, but I don't think this is a huge deal.

We've got some bigger questions about the state of this code, and fixing complex bugs like this in code that might get rewritten doesn't feel like the best usage of time, if we can live with alternative solutions for now.

Comment 7

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Should be lower risk because it's just deleting code.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b648b684325
Remove code that changes the size of the pocket doorhanger for non premium users if you try to enter a tag r=gvn

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4b648b684325

Comment 10

[Scott [:thecount] Downe]

Comment on attachment 9179404 [details]
Bug 1668307 - Remove code that changes the size of the pocket doorhanger for non premium users if you try to enter a tag

Beta/Release Uplift Approval Request

• User impact if declined: This would likely impact turning this on 1666588, which would contribute to our reach goals.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the Firefox browser.
  Log into a Pocket account.
  Navigate to the following link https://www.makeuseof.com/tag/get-more-out-of-pocket-with-these-6-tips-to-enhance-your-reading-experience/
  Click the "Save to Pocket" button from the right part of the "Address Bar".
  Click inside the tags field text.
  Click the greyed-out “Save” button.
  Observe the behavior.

[Expected result]:

Nothing happens given that the “Save” button is greyed-out.

[Actual result]:

Only 2 suggestions remain displayed in the doorhanger, the rest of the elements are removed.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Should be lower risk because it's just deleting code.
• String changes made/needed: none

Comment 11

[Pascal Chevrel:pascalc (PTO until Sept 2)]

No need to track for 83 as this is already landed and we are in the nightly cycle.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9179404 [details]
Bug 1668307 - Remove code that changes the size of the pocket doorhanger for non premium users if you try to enter a tag

approved for 82.0b8

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/92fe4f5a33c4

Comment 14

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

• I have verified that this issue is no longer reproducible with the latest Firefox Nightly (83.0a1 Build ID - 20201006041051) installed, on Windows 10 x64, Ubuntu 20.04 x64, and Mac 10.15.
• Now I can confirm that the doorhanger sections are not removed when clicking the "Save" button after previously focusing the tags input field.

Comment 15

[Carmen Fat [:cfat] - Ecosystem QA, PTO until August 22nd - NI to: [e-mail]]

• I have verified that this issue is no longer reproducible with the latest Firefox Beta (82.0b9 Build ID - 20201008183927) installed, on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15.
• Now I can confirm that the doorhanger sections are not removed when clicking the "Save" button after previously focusing the tags input field.