1668360 - Invert WebRender gfx features configurations to be enabled by default

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Andrew Osmond [:aosmond] (he/him)]

This will make it clearer why we didn't get a feature.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1668360 - Invert WebRender feature config to be enabled by default.

This has no functional change beyond our telemetry reporting. It inverts
our feature configuration such that we get an explicit reason why we
don't turn on some features, instead of just "disabled by default."

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a501f5b443d
Invert WebRender feature config to be enabled by default. r=jrmuizel

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for marionette gpu failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/bb5934b5ca2086e08ccb74f849fe450e22121ce7
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317226270&repo=autoland&lineNumber=1176

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Didn't realize there was a test checking for opt-in specifically vs another disabled reason. Waiting on try now to verify the fix.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca06f340d0ad
Invert WebRender feature config to be enabled by default. r=jrmuizel

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ca06f340d0ad

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9178830 [details]
Bug 1668360 - Invert WebRender feature config to be enabled by default.

Beta/Release Uplift Approval Request

• User impact if declined: No functional change, but it does improve our telemetry collection as to why users don't get WebRender. It would be useful to get data from release as soon as possible.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have unit tests written to verify the configuration works the same.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

We're about to build the last 82 beta, how critical is this?

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9178830 [details]
Bug 1668360 - Invert WebRender feature config to be enabled by default.

I'm going to call this wontfix for 82, sorry.