1668362 - The clickable magnifying glass in the search-box in any translation page does not work

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Enrico]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Open https://pontoon.mozilla.org/it/terminology/common, write in the top-left visible search bar and click the magnifying glass

Actual results:

Nothing

Expected results:

Same input as Enter on keyboard: search goes through and I can see results of my search in the left panel.

Comment 1

[Matjaz Horvat [:mathjazz]]

Enrico: could you please clarify why did you expect Pontoon to search after clicking on the magnifying glass icon?

I checked a few sites (e.g. Bugzilla, Twitter, Google, Facebook) and none of them seems to trigger search after clicking on the icon.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Matjaz Horvat [:mathjazz] from comment #1)

Enrico: could you please clarify why did you expect Pontoon to search after clicking on the magnifying glass icon?

The main source of confusion is that the icon acts like a button and cursor changes when hovered.

Comment 3

[Matjaz Horvat [:mathjazz]]

In this case I'd just change the cursor to text.

Comment 4

[Enrico]

(In reply to Matjaz Horvat [:mathjazz] from comment #1)

Enrico: could you please clarify why did you expect Pontoon to search after clicking on the magnifying glass icon?

I checked a few sites (e.g. Bugzilla, Twitter, Google, Facebook) and none of them seems to trigger search after clicking on the icon.

It changes the cursor to pointer when hovered, and apparently it used to work till recently.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1698

Comment 6

[Matjaz Horvat [:mathjazz]]

I've opened a PR and deployed the patch to stage:
https://github.com/mozilla/pontoon/pull/1698

Could one of you two please review / verify it?

Comment 7

[Enrico]

(In reply to Matjaz Horvat [:mathjazz] from comment #6)

I've opened a PR and deployed the patch to stage:
https://github.com/mozilla/pontoon/pull/1698

Could one of you two please review / verify it?

It successfully doesn't show the pointer any more, and if I click on the icon, the cursor for writing the input appears in the search box and I can write the search query.

So I'd say it's all good.

Comment 8

[Matjaz Horvat [:mathjazz]]

Thanks!