1668372 - GMP extraction fails if path to temporary files contains a # character

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

See https://support.mozilla.org/en-US/questions/1302754#answer-1354535

Something in the GMPExtractor[0] machinery fails if there's a # on the path to the temp directory where the GMP zips are downloaded to.

STR:

• Create a user with a # character in their name (e.g. Test#).
• Run Firefox with that user account.
• Navigate to https://shaka-player-demo.appspot.com/demo/#build=uncompiled
• The plugins installing notification will appear and only be removed when install times out, the browser console (Ctrl + Shift + J) wil show errors.

Further notes:

• I've tested and this is a problem even if the profile dir is outside that path.
• The temp files exist in the temporary directory, so it looks like they're downloaded, but it's the extraction which is failing.

[0] https://searchfox.org/mozilla-central/rev/f21850ca45036ddb84cd25aa355a6969d7c94c4f/toolkit/modules/GMPInstallManager.jsm#512

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1668372 - Escape URI GMP zips are extracted from. r?gijs

Users with certain special characters on the path to the temp dirs where GMPs
are saved would not be able to extract GMPS. This fixes this by escaping
characters such as # so that the URIs to the file are treated correctly.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1668372 - Test GMPExtractor handles special characters. r?gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac12524936de
Test GMPExtractor handles special characters. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/91cfeac746aa
Escape URI GMP zips are extracted from. r=Gijs

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ac12524936de
https://hg.mozilla.org/mozilla-central/rev/91cfeac746aa