1668398 - Vendor Cranelift to get Wasm ABI-2020 support

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Description

[Chris Fallin [:cfallin]]

In order to support the new Wasm ABI when using a Cranelift-based backend (bug 1657802), we need to pull in a version of Cranelift that includes PR #2223. We should be able to vendor this independently of the rest of the ABI patches, because the Cranelift-side support exists as a new ABI option.

Comment 1

[Chris Fallin [:cfallin]]

Attachment: Bug 1668398: vendor Cranelift 57fed697920cb888c6cb7e406d13518f7edd12ea. r=bbouvier

This patch pulls in the latest version of Cranelift, which includes
necessary updates to support some recent work on the Wasm backend (e.g.,
support for the new ABI in PR #2223).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a01ad5e890
vendor Cranelift b8f0dc429f2b886e7423122223393b2c7ee3cd4f. r=bbouvier

Comment 3

[Atila Butkovits]

Backed outfor bustages complaining about ABIMachineSpec.

Backout link: https://hg.mozilla.org/integration/autoland/rev/449d7bd24c892aa4ab0c1498e8baa4ef698caf92

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=92a01ad5e890aeda140d46dc4d075bca585d45c4&searchStr=build&selectedTaskRun=NMluZocKQBqQQgRizCJhfA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317343365&repo=autoland&lineNumber=27398

Comment 4

[Chris Fallin [:cfallin]]

Hmm. This failure is due to some bitrot in an experimental new ARM32 backend in Cranelift; it appears that on the Cranelift side, the arm32 build-config feature means "new experimental backend", while on the SpiderMonkey side, we pass arm32 just to mean "hey we're on an ARM32 machine". Unfortunate overloading of this feature name loads to an inadvertent build dependency (although it appears we'd never actually invoke the Cranelift backend).

On the Cranelift side, I have a fix for the bitrot here (#2259) and I'll look into adding a build-only test to our CL/wasmtime CI. On the SpiderMonkey side, I think we should exclude Cranelift altogether on platforms that are not explicitly x86-64 or aarch64. I'll create a separate patch for that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d548bb7ebca0
vendor Cranelift 57fed697920cb888c6cb7e406d13518f7edd12ea. r=bbouvier

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d548bb7ebca0