Closed Bug 1668505 Opened 4 years ago Closed 3 years ago

Make SessionStorageCache have one dataset

Categories

(Core :: Storage: localStorage & sessionStorage, enhancement)

Product:
Core
Component:
Storage: localStorage & sessionStorage
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1710004

People

(Reporter: tt, Unassigned)

References

Details

Quote from https://phabricator.services.mozilla.com/D89342?id=336051#inline-515158:

Current code indicates that mIsSessionOnly is set only during storage object construction:
https://searchfox.org/mozilla-central/rev/b58ca45005fe02077c92779483d1b60e9a49687c/dom/storage/Storage.cpp#46

It used to be set dynamically, the first time it stopped being set dynamically for session storage:
https://hg.mozilla.org/mozilla-central/rev/9957d3e640736942b95c21dad5cfea3192cc1e96#l1.155

Now SessionStorageCache owns two datasets and syncs them between the parent process and content process.

I think we can:

  • Remove SessionStorageCache one dataset since it cannot happen that SessionStorageCache maintains two datasets during runtime
  • Remove aDataSetType for all SessionStorageCache's member functions
  • Remove the extra dataset parameter for IPC message for syncing SessionStorageCache between processes.
  • Consts the mIsSessionOnly
  • Adds some debug assertions

This was fixed by :farre in bug 1710004. Hooray!

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.