1668531 - Move IsCacheableDOMProxy and clean-up some includes in js/jit

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[André Bargull [:anba]]

IsCacheableDOMProxy is only used in CacheIR.cpp, so we can move it from BaselineIC.h into that file. After that we can clean-up some includes in BaselineIC.h. And that was followed by more includes clean-ups elsewhere...

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 1: Move IsCacheableDOMProxy into CacheIR.cpp. r=jandem!

And then fixup the missing includes which were previously transitively
included through BaselineIC.h.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 2: Add missing includes and forward declarations to BaselineIC.h. r=jandem!

Depends on D92048

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 3: Remove unnecessary includes from BaselineIC.h. r=jandem!

Depends on D92049

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 4: Remove JS_DISASM_SUPPORTED guarded include. r=jandem!

JS_DISASM_SUPPORTED is defined exactly once in the code base and that's after
this guarded include. But that means the include is never used and hence can
be removed.

Depends on D92050

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 5: Clean-up includes for Disassembler-shared. r=jandem!

Add missing resp. remove unnecessary includes. Also use forward declarations
instead of using declarations.

Additional changes needed:

MozBaseAssembler-vixl.h:

• Include "jit/Label.h" for jit::Label.

Depends on D92051

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 6: Remove unnecessary includes in IonTypes.h. r=jandem!

Additional changes needed:

ObjectGroup.h:

• Include "gc/Allocator.h" for gc::InitialHeap

Simulator-arm.h:

• Include "js/AllocPolicy.h" for SystemAllocPolicy.

Depends on D92052

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 7: Clean-up includes for RegisterSets.h. r=jandem!

Changes Value to JS::Value because "NamespaceImports.h" is no longer
transitively included.

Depends on D92053

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 8: Clean-up includes for JitContext.h. r=jandem!

Additional changes needed:

CompileInfo.h:

• Include "jit/CompileWrappers.h" for js::jit::CompileRuntime

IonAnalysis.h:

• Include "mozilla/Attributes.h" for MOZ_MUST_USE
• Include "vm/TypeInference.h" for js::DPAConstraintInfo and js::TypeNewScriptInitializer

Label.h:

• Include "jit/CompileWrappers.h" for js::jit::CompileRuntime
• Include "js/Utility.h" for js::oom::HadSimulatedOOM().

RegExpShim.h:

• Include "js/RegExpFlags.h" for JSRegExp::Flags
• Include "vm/RegExpShared.h" for js::RegExpShared

Depends on D92054

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 9: Move jit::Label destructor out-of-line. r=jandem!

Move jit::Label destructor out-of-line, that way we can avoid multiple
debug-only includes in Label.h.

Depends on D92055

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 10: Clean-up includes for ThrowMsgKind. r=jandem!

"jsfriendapi.h" can be replaced with the new "js/friend/ErrorMessages.h" header.

Additional changes needed:

BytecodeUtil.h

• Remove unused PcVector so we don't need to pull in "js/AllocPolicy.h" for SystemAllocPolicy

Depends on D92056

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 11: Clean-up includes for BytecodeUtil.h. r=jandem!

Depends on D92057

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 12: Clean-up includes for IdValuePair.h. r=jandem!

• Include for "jsapi.h" wasn't necessary at all.
• "NamespaceImports.h" pulls in many headers, so it was replaced with
  "js/Value.h".
• Without "NamespaceImports.h" Value and UndefinedValue need to be prepended
  with JS::.

Depends on D92058

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1668531 - Part 13: Remove unnecessary CompilationAndEvaluation.h include from Runtime.h. r=jandem!

"js/CompilationAndEvaluation.h" doesn't need to be included in "vm/Runtime.h".

Depends on D92059

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4080393d0269
Part 1: Move IsCacheableDOMProxy into CacheIR.cpp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/652ef517fcd9
Part 2: Add missing includes and forward declarations to BaselineIC.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b9ef794434ec
Part 3: Remove unnecessary includes from BaselineIC.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/4348ec046df8
Part 4: Remove JS_DISASM_SUPPORTED guarded include. r=jandem
https://hg.mozilla.org/integration/autoland/rev/961f77ca2cf8
Part 5: Clean-up includes for Disassembler-shared. r=jandem
https://hg.mozilla.org/integration/autoland/rev/af0c4d738960
Part 6: Remove unnecessary includes in IonTypes.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ebd21b344280
Part 7: Clean-up includes for RegisterSets.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/50329bd48d5b
Part 8: Clean-up includes for JitContext.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/13bccdf72309
Part 9: Move jit::Label destructor out-of-line. r=jandem
https://hg.mozilla.org/integration/autoland/rev/0a205bd06fa7
Part 10: Clean-up includes for ThrowMsgKind. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d8a252759ff4
Part 11: Clean-up includes for BytecodeUtil.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c3881fe13740
Part 12: Clean-up includes for IdValuePair.h. r=jandem
https://hg.mozilla.org/integration/autoland/rev/acad63c3a51f
Part 13: Remove unnecessary CompilationAndEvaluation.h include from Runtime.h. r=jandem

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4080393d0269
https://hg.mozilla.org/mozilla-central/rev/652ef517fcd9
https://hg.mozilla.org/mozilla-central/rev/b9ef794434ec
https://hg.mozilla.org/mozilla-central/rev/4348ec046df8
https://hg.mozilla.org/mozilla-central/rev/961f77ca2cf8
https://hg.mozilla.org/mozilla-central/rev/af0c4d738960
https://hg.mozilla.org/mozilla-central/rev/ebd21b344280
https://hg.mozilla.org/mozilla-central/rev/50329bd48d5b
https://hg.mozilla.org/mozilla-central/rev/13bccdf72309
https://hg.mozilla.org/mozilla-central/rev/0a205bd06fa7
https://hg.mozilla.org/mozilla-central/rev/d8a252759ff4
https://hg.mozilla.org/mozilla-central/rev/c3881fe13740
https://hg.mozilla.org/mozilla-central/rev/acad63c3a51f