1668577 - Make child process to send offset to parent process, not index

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

consecutive
history.back(); history.back();
is problematic currently.
It is tested by popstate_event.html

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1668577 - Make child process to send offset to parent process, not index, r=peterv

The patch takes rather conservative approach in ChildSHistory and passes index for old implementation and new
one can use offset. Once nsDocShell::GotoIndex and similar go away, this can be simplified.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3729165fa131ced229716a4c70136d7232b9d496

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3cbffeb24a3
Make child process to send offset to parent process, not index, r=peterv

Comment 4

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=wpt&revision=62112d7e4fd9e6931ca7c246ef6ef3c4d1dd4727&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317398232&repo=autoland&lineNumber=4846

Backout: https://hg.mozilla.org/integration/autoland/rev/eb9fbdec50a13c43e4c10dca4e0b344fe3bbf3a2

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Based on the discussion in Matrix, this didn't seem to be the cause for the failures.
Trying to reland.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/573659457e9c
Make child process to send offset to parent process, not index, r=peterv

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/573659457e9c