Closed
Bug 1668598
Opened 5 years ago
Closed 5 years ago
Improve AudioData naming and correctness
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
Details
Attachments
(1 file)
jya in https://phabricator.services.mozilla.com/D91776#2947679:
The naming is incorrect: The length contains the number of objects, while size indicates the number of bytes it's actually using.
That changes makes me realise that PopFront is broken too and only works because it's only called from MediaRawData where length == size. This won't be the case with an AudioData.
Can you fix that on the fly too while at it?
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → padenot
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9179585 -
Attachment description: Bug 1668598 - Don't use the word \'size\' to mean a number of elements in MediaData.h. r?jya → Bug 1668598 - Don't use the word 'size' to mean a number of elements in MediaData.h. r?jya
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35c894fe1062
Don't use the word 'size' to mean a number of elements in MediaData.h. r=jya
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•