1668665 - Leave print preview open if the user cancels saving as pdf

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P2)

Description

[Emma Malysz]

If the user cancels saving, we should enable the elements of the form and allow them to interact with the print dialog.

Comment 1

[Emma Malysz]

Attachment: Bug 1668665, ensure we do not close dialog if user cancels saving as pdf

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ac18698c3e5
ensure we do not close dialog if user cancels saving as pdf r=mstriemer,sfoster

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4ac18698c3e5

Comment 4

[Emma Malysz]

Comment on attachment 9179123 [details]
Bug 1668665, ensure we do not close dialog if user cancels saving as pdf

Beta/Release Uplift Approval Request

• User impact if declined: The entire dialog will cancel if the user cancels save as PDF, which is an awkward flow
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the new print preview

2. Select "Save as pdf printer"
3. Click save
4. Cancel the file picker dialog
5. Note that you return to print dialog with same elements that were enabled as before the user saved

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes
• String changes made/needed: n/a

Comment 5

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 84.0a1 (BuildId:20201025214116) on Windows 10 64bit, macOS 10.15 & Ubuntu 18.04 64bit. The print preview remains open if the file picker is closed/canceled.

Leaving the qe-verify+ flag and a ni? on myself as a reminder to verify this in beta once it lands.

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9179123 [details]
Bug 1668665, ensure we do not close dialog if user cancels saving as pdf

Verified by QA on nightly, uplift approved for 83 beta 5, thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef8bb96f0c69

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 83.0b8 (BuildId:20201103183834) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04