1668824 - On macOS and Windows, prefer ffmpeg to decode mp3s

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Paul Adenot (:padenot)]

It's easier to have a single path.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1668824 - On macOS and Windows, prefer ffmpeg to decode mp3s. r?jya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2834ef721441
On macOS and Windows, prefer ffmpeg to decode mp3s. r=jya

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for build bustage on AppleDecoderModule.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/0d21a81831807b9d12d6887d9213c8a9bc628822

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2834ef721441979a69a4675d1cd1761573315742&selectedTaskRun=CgZhC1ykT_SUvnBojZxQKQ.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317411315&repo=autoland&lineNumber=14801

[task 2020-10-02T17:13:51.058Z] 17:13:51 INFO - In file included from Unified_cpp_dom_media_platforms0.cpp:137:
[task 2020-10-02T17:13:51.059Z] 17:13:51 ERROR - /builds/worker/checkouts/gecko/dom/media/platforms/apple/AppleDecoderModule.cpp:77:25: error: no member named 'media_ffmpeg_mp3_enabled' in namespace 'mozilla::StaticPrefs'; did you mean 'media_ffvpx_mp3_enabled'?
[task 2020-10-02T17:13:51.059Z] 17:13:51 INFO - !StaticPrefs::media_ffmpeg_mp3_enabled()) ||
[task 2020-10-02T17:13:51.059Z] 17:13:51 INFO - ^
[task 2020-10-02T17:13:51.059Z] 17:13:51 INFO - media_ffvpx_mp3_enabled
[task 2020-10-02T17:13:51.059Z] 17:13:51 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPrefList_media.h:307:4: note: 'media_ffvpx_mp3_enabled' declared here
[task 2020-10-02T17:13:51.059Z] 17:13:51 INFO - media_ffvpx_mp3_enabled,
[task 2020-10-02T17:13:51.060Z] 17:13:51 INFO - ^
[task 2020-10-02T17:13:51.060Z] 17:13:51 INFO - 1 error generated.
[task 2020-10-02T17:13:51.060Z] 17:13:51 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:723: Unified_cpp_dom_media_platforms0.o] Error 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7d703696a6a
On macOS and Windows, prefer ffmpeg to decode mp3s. r=jya

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d7d703696a6a