1668845 - GV renders bottom toolbar placeholder when changing scroll flags

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Steps to reproduce

• in Fenix have the dynamic toolbar set at top.
• access http://bela-lugosi.de (always happening on this website which has 100% width and height)
• after the animations end tap a few time the webpage

Expected behavior

• The page should be rendered fully, not being clipped off.

Actual behavior

GV renders at it's bottom a blank space with the same height as set in setDynamicToolbarMaxHeight.
Observed that this consistently happens because tapping on the screen gets to set different scroll flags(basically NO_SCROLL / SCROLL).

Seen in this video:

• when the page is loaded based on engineView.getInputResult we set SCROLL_FLAG_SCROLL (the page is rendered fully)
• first tap sets SCROLL_FLAG_NO_SCROLL (the page is now cutoff at the bottom)
• second tap sets SCROLL_FLAG_SCROLL (the page is again rendered fully)
• third tap sets again SCROLL_FLAG_NO_SCROLL (the page is now again clipped, even after a refresh)

Given that this blank space is rendered by GV and only on specific websites I think this is a layout issue in GV.

Device information

• Android device: Device independent.
• Fenix version: Happens in both GV 83 (Fenix Nightly) and on GV 81 (Fenix Release)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Though I haven't looked into detail about what happens on the tap, the body element is slightly taller than the browser height - the toolbar height because of margins.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I can no longer see this issue on a local built Fenix with bug 1663000.

Petru, can you please do double-check?

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Also cannot reproduce.
Thank you!
Will add the qa-needed flag on Fenix - https://github.com/mozilla-mobile/fenix/issues/7534 to have that verified and closed on Fenix also.

Comment 4

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.