Closed Bug 1668851 Opened 4 years ago Closed 4 years ago

CI view on libwebsockets.org broken by bug 1497249

Categories

(Core :: Networking: WebSockets, defect, P1)

Product:
Core
Component:
Networking: WebSockets
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- verified
firefox83 --- verified

People

(Reporter: denschub, Assigned: kershaw)

References

(Regression,
URL
)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1668851 - Try to write data to socket directly without waiting
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

The CI view at https://libwebsockets.org/sai/index.html loads it's data via a WebSocket. Currently, this is broken in Firefox.

From a quick look, this looks like the payload is never received by Firefox. In the original WebCompat report, the author noted that this used to work, but is no longer working, but there is no visible error anywhere. However, I notice a bunch of possibly related exceptions in the browser console.

Running mozregression pointed towards bug 1497249 as the cause. :kershaw, could you have a look at this?

Flags: needinfo?(kershaw)
Assignee: nobody → kershaw
Severity: -- → S2
Flags: needinfo?(kershaw)
Priority: -- → P1
Whiteboard: [necko-triaged]

Compared to the implement before bug 1497249, I found I did something not correctly.

  1. In current implementation, we put the data to the queue and call AsyncWait to send data. This causes the data can't be sent out immediately. I think this is the root cause of this bug.
  2. CallAcknowledge is called without waiting the data been really sent out. In previous implementation, CallAcknowledge is called after the payload is completely written.
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eff866cb4c66 Try to write data to socket directly without waiting r=necko-reviewers,dragana

Backed out changeset eff866cb4c66 (bug 1668851) for browser_net-ws-filter-freetext.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=NlpoO5OSTHuqJeNAv3Ttkg.0&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-spi-nw-e10s%2Cdt10&fromchange=3e90ffb5ed1529395af37ca6fca469fd6a03ba00&tochange=19bc84a9ed83efac55c260d5437c3426eeb36b49

Backout link: https://hg.mozilla.org/integration/autoland/rev/d33f48b9f0630302094ea94138106a3e99489783

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317729010&repo=autoland&lineNumber=2295

[task 2020-10-06T09:14:20.376Z] 09:14:20     INFO - TEST-START | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js
[task 2020-10-06T09:14:21.040Z] 09:14:21     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f5f3b09e800 == 2 [pid = 1625] [id = 1]
[task 2020-10-06T09:14:21.043Z] 09:14:21     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7f5f57793180) [pid = 1625] [serial = 5] [outer = (nil)]
[task 2020-10-06T09:14:21.044Z] 09:14:21     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x7f5f3b09f800) [pid = 1625] [serial = 6] [outer = 0x7f5f57793180]
[task 2020-10-06T09:14:21.141Z] 09:14:21     INFO - GECKO(1491) | [Child 1625, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp, line 348
[task 2020-10-06T09:14:21.152Z] 09:14:21     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x7f5f3b0a2800) [pid = 1625] [serial = 7] [outer = 0x7f5f57793180]
[task 2020-10-06T09:14:21.716Z] 09:14:21     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fb6d519d000 == 8 [pid = 1491] [id = 7]
[task 2020-10-06T09:14:21.716Z] 09:14:21     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x7fb6d51c36a0) [pid = 1491] [serial = 16] [outer = (nil)]
[task 2020-10-06T09:14:21.792Z] 09:14:21     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 17 (0x7fb6d52ec000) [pid = 1491] [serial = 17] [outer = 0x7fb6d51c36a0]
[task 2020-10-06T09:14:21.820Z] 09:14:21     INFO - GECKO(1491) | [Child 1625, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp, line 6898
[task 2020-10-06T09:14:21.840Z] 09:14:21     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 18 (0x7fb6d52f7c00) [pid = 1491] [serial = 18] [outer = 0x7fb6d51c36a0]
[task 2020-10-06T09:14:21.998Z] 09:14:21     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp, line 3779
[task 2020-10-06T09:14:22.242Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fb6d52ed400 == 9 [pid = 1491] [id = 8]
[task 2020-10-06T09:14:22.244Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 19 (0x7fb6d51c22b0) [pid = 1491] [serial = 19] [outer = (nil)]
[task 2020-10-06T09:14:22.244Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp, line 347
[task 2020-10-06T09:14:22.244Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 20 (0x7fb6eb153c00) [pid = 1491] [serial = 20] [outer = 0x7fb6d51c22b0]
[task 2020-10-06T09:14:22.422Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp, line 1132
[task 2020-10-06T09:14:22.843Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, nullptr) failed with result 0x804B000A (NS_ERROR_MALFORMED_URI): file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 46
[task 2020-10-06T09:14:22.844Z] 09:14:22     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: NS_ENSURE_TRUE(principal) failed: file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 58
[task 2020-10-06T09:14:23.448Z] 09:14:23     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x7f5f3b339c00) [pid = 1625] [serial = 8] [outer = 0x7f5f57793180]
[task 2020-10-06T09:14:23.708Z] 09:14:23     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f5f413e2400 == 1 [pid = 1625] [id = 0] [url = about:blank]
[task 2020-10-06T09:14:26.107Z] 09:14:26     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fb6dc210400 == 8 [pid = 1491] [id = 4] [url = about:blank]
[task 2020-10-06T09:14:26.108Z] 09:14:26     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fb6dc20d400 == 7 [pid = 1491] [id = 5] [url = about:blank]
[task 2020-10-06T09:14:26.525Z] 09:14:26     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 19 (0x7fb6dd4cd600) [pid = 1491] [serial = 11] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:26.526Z] 09:14:26     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 18 (0x7fb6dd4cd090) [pid = 1491] [serial = 10] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:27.849Z] 09:14:27     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7f5f3b09f800) [pid = 1625] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:27.849Z] 09:14:27     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f5f3b042400) [pid = 1625] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:27.909Z] 09:14:27     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f5f57793520) [pid = 1625] [serial = 1] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:28.232Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x7f7d61740000) [pid = 1644] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:28.232Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7f7d614b1000) [pid = 1644] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:28.233Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7f7d614aec00) [pid = 1644] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:28.233Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7f7d61455800) [pid = 1644] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:28.293Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f7d67797800 == 3 [pid = 1644] [id = 0] [url = moz-extension://6b07475b-43f8-461a-b671-fe98ca3fab7a/_generated_background_page.html]
[task 2020-10-06T09:14:28.294Z] 09:14:28     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7f7d7db93520) [pid = 1644] [serial = 1] [outer = (nil)] [url = moz-extension://6b07475b-43f8-461a-b671-fe98ca3fab7a/_generated_background_page.html]
[task 2020-10-06T09:14:30.703Z] 09:14:30     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (0x7fb6e10bc400) [pid = 1491] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:30.704Z] 09:14:30     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (0x7fb6d52ec000) [pid = 1491] [serial = 17] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:30.704Z] 09:14:30     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x7fb6deb49c00) [pid = 1491] [serial = 12] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:30.719Z] 09:14:30     INFO - GECKO(1491) | [Parent 1491: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7fb6e101f000) [pid = 1491] [serial = 13] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:31.383Z] 09:14:31     INFO - GECKO(1491) | [Child 1708: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7f25d6b4d000) [pid = 1708] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:31.950Z] 09:14:31     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f5f4140a400) [pid = 1625] [serial = 3] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:31.950Z] 09:14:31     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f5f3b04ac00) [pid = 1625] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2020-10-06T09:14:31.951Z] 09:14:31     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7f5f3b0a2800) [pid = 1625] [serial = 7] [outer = (nil)] [url = http://mochi.test:8888/browser/devtools/client/netmonitor/test/html_ws-test-page.html]
[task 2020-10-06T09:14:32.333Z] 09:14:32     INFO - GECKO(1491) | [Child 1644: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f7d61747400) [pid = 1644] [serial = 9] [outer = (nil)] [url = moz-extension://6b07475b-43f8-461a-b671-fe98ca3fab7a/_generated_background_page.html]
[task 2020-10-06T09:15:50.602Z] 09:15:50     INFO - TEST-INFO | started process screentopng
[task 2020-10-06T09:15:50.908Z] 09:15:50     INFO - TEST-INFO | screentopng: exit 0
[task 2020-10-06T09:15:50.908Z] 09:15:50     INFO - Buffered messages logged at 09:14:20
[task 2020-10-06T09:15:50.908Z] 09:15:50     INFO - Entering test bound 
[task 2020-10-06T09:15:50.908Z] 09:15:50     INFO - Initializing a network monitor pane.
[task 2020-10-06T09:15:50.908Z] 09:15:50     INFO - Adding a new tab with URL: http://mochi.test:8888/browser/devtools/client/netmonitor/test/html_ws-test-page.html
[task 2020-10-06T09:15:50.912Z] 09:15:50     INFO - Buffered messages logged at 09:14:21
[task 2020-10-06T09:15:50.912Z] 09:15:50     INFO - Tab added and finished loading
[task 2020-10-06T09:15:50.912Z] 09:15:50     INFO - Net tab added successfully: http://mochi.test:8888/browser/devtools/client/netmonitor/test/html_ws-test-page.html
[task 2020-10-06T09:15:50.912Z] 09:15:50     INFO - Buffered messages logged at 09:14:23
[task 2020-10-06T09:15:50.912Z] 09:15:50     INFO - Network monitor pane shown successfully.
[task 2020-10-06T09:15:50.913Z] 09:15:50     INFO - Disabling cache and reloading page.
[task 2020-10-06T09:15:50.914Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 0/1, PayloadReady: 1/1, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn0.netEvent5
[task 2020-10-06T09:15:50.914Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn0.netEvent5
[task 2020-10-06T09:15:50.916Z] 09:15:50     INFO - Got marker: dom-interactive
[task 2020-10-06T09:15:50.916Z] 09:15:50     INFO - Console message: [JavaScript Warning: "Relative positioning of table rows and row groups is now supported. This site may need to be updated because it may depend on this feature having no effect." {file: "resource://devtools/client/netmonitor/src/components/request-list/RequestListHeader.js" line: 545}]
[task 2020-10-06T09:15:50.916Z] 09:15:50     INFO - Buffered messages logged at 09:14:24
[task 2020-10-06T09:15:50.917Z] 09:15:50     INFO - Got marker: dom-complete
[task 2020-10-06T09:15:50.917Z] 09:15:50     INFO - Got two timeline markers, done waiting
[task 2020-10-06T09:15:50.918Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, EventTimings: 1/1, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn0.netEvent5
[task 2020-10-06T09:15:50.918Z] 09:15:50     INFO - Clearing requests in the UI.
[task 2020-10-06T09:15:50.918Z] 09:15:50     INFO - Starting test... 
[task 2020-10-06T09:15:50.927Z] 09:15:50     INFO - Console message: [JavaScript Error: "Unknown Collection "main/partitioning-exempt-urls"" {file: "resource://services-settings/RemoteSettingsClient.jsm" line: 160}]
[task 2020-10-06T09:15:50.927Z] 09:15:50     INFO - UnknownCollectionError@resource://services-settings/RemoteSettingsClient.jsm:160:5
[task 2020-10-06T09:15:50.927Z] 09:15:50     INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:470:13
[task 2020-10-06T09:15:50.927Z] 09:15:50     INFO - async*get/this._importingPromise<@resource://services-settings/RemoteSettingsClient.jsm:370:26
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - async*get@resource://services-settings/RemoteSettingsClient.jsm:372:13
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - async*lazyInit@resource://gre/modules/PartitioningExceptionListService.jsm:111:26
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - registerAndRunExceptionListObserver@resource://gre/modules/PartitioningExceptionListService.jsm:135:10
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - 
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 1/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn0.netEvent24
[task 2020-10-06T09:15:50.928Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 0/2, PayloadReady: 2/2, EventTimings: 0/0, got NetMonitor:PayloadReady for server0.conn0.netEvent45
[task 2020-10-06T09:15:50.929Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 1/2, PayloadReady: 2/2, EventTimings: 0/1, got NetMonitor:NetworkEvent for server0.conn0.netEvent24
[task 2020-10-06T09:15:50.930Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 0/2, got NetMonitor:NetworkEvent for server0.conn0.netEvent45
[task 2020-10-06T09:15:50.930Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 1/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn0.netEvent24
[task 2020-10-06T09:15:50.930Z] 09:15:50     INFO - > Network event progress: NetworkEvent: 2/2, PayloadReady: 2/2, EventTimings: 2/2, got NetMonitor:NetworkEventUpdated:EventTimings for server0.conn0.netEvent45
[task 2020-10-06T09:15:50.930Z] 09:15:50     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js | There should be two requests - 
[task 2020-10-06T09:15:50.931Z] 09:15:50     INFO - Buffered messages logged at 09:14:25
[task 2020-10-06T09:15:50.931Z] 09:15:50     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js | There should be six frames - 
[task 2020-10-06T09:15:50.931Z] 09:15:50     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1210}]
[task 2020-10-06T09:15:50.931Z] 09:15:50     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1210}]
[task 2020-10-06T09:15:50.932Z] 09:15:50     INFO - Buffered messages finished
[task 2020-10-06T09:15:50.932Z] 09:15:50     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js | Test timed out - 
[task 2020-10-06T09:15:50.932Z] 09:15:50     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp, line 1598
[task 2020-10-06T09:15:51.865Z] 09:15:51     INFO - Removing tab.
[task 2020-10-06T09:15:51.866Z] 09:15:51     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-10-06T09:15:51.896Z] 09:15:51     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-10-06T09:15:51.919Z] 09:15:51     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp, line 172
[task 2020-10-06T09:15:51.921Z] 09:15:51     INFO - GECKO(1491) | [Parent 1491, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp, line 172
[task 2020-10-06T09:15:51.922Z] 09:15:51     INFO - Tab removed and finished closing
[task 2020-10-06T09:15:51.964Z] 09:15:51     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-10-06T09:15:51.964Z] 09:15:51     INFO - finish() was called, cleaning up...
[task 2020-10-06T09:15:52.001Z] 09:15:52     INFO - GECKO(1491) | [Child 1625, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp, line 291
[task 2020-10-06T09:15:52.002Z] 09:15:52     INFO - GECKO(1491) | [Child 1625, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp, line 291
[task 2020-10-06T09:15:52.002Z] 09:15:52     INFO - GECKO(1491) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2020-10-06T09:15:52.003Z] 09:15:52     INFO - GECKO(1491) | MEMORY STAT | vsize 3071MB | residentFast 377MB | heapAllocated 107MB
[task 2020-10-06T09:15:52.003Z] 09:15:52     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net-ws-filter-freetext.js | took 91623ms
[task 2020-10-06T09:15:52.019Z] 09:15:52     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f5f3b049000 == 2 [pid = 1625] [id = 2]
[task 2020-10-06T09:15:52.019Z] 09:15:52     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7f5f57793520) [pid = 1625] [serial = 9] [outer = (nil)]
[task 2020-10-06T09:15:52.021Z] 09:15:52     INFO - GECKO(1491) | [Child 1625: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7f5f3b04a800) [pid = 1625] [serial = 10] [outer = 0x7f5f57793520]
[task 2020-10-06T09:15:52.061Z] 09:15:52     INFO - checking window state
Flags: needinfo?(kershaw)

There are two tests failed when socket process is enabled. I think we can disable them on socket process for now.

Flags: needinfo?(kershaw)
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da4cf62e21fb Try to write data to socket directly without waiting r=necko-reviewers,dragana
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e85b98e5a5bf Try to write data to socket directly without waiting r=necko-reviewers,dragana,remote-protocol-reviewers

https://hg.mozilla.org/mozilla-central/rev/e85b98e5a5bf

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

Can we live with this bug on 82 or do we need to uplift for the release candidate?

Flags: needinfo?(kershaw)

I'd suggest to uplift this.

Flags: needinfo?(kershaw)

Comment on attachment 9179608 [details]
Bug 1668851 - Try to write data to socket directly without waiting

Beta/Release Uplift Approval Request

  • User impact if declined: Some sites using websocket may not work.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Open this webs site https://libwebsockets.org/sai/index.html and see if things are loaded.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): I'd say the risk to cause regression is low, since this patch passed all our websocket tests.
  • String changes made/needed: None
Attachment #9179608 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I verified that the page fully loads on Firefox 83.0a1 (2020-10-11). Tests were performed on macOS 11, Windows 10 and Ubuntu 20.04. Will verify too when this will get on 82 as well.

status-firefox83: fixed → verified

Comment on attachment 9179608 [details]
Bug 1668851 - Try to write data to socket directly without waiting

approved for 82 rc1

Attachment #9179608 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as well on 82.0 RC and the page fully loads as expected. Tests were performed on macOS 10.15.7, Windows 10 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
status-firefox82: fixed → verified
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: