1668904 - Calendar event display issue: event Location text not constrained to within graphical event block

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[davelabrecque]

Attachment: Event location text display overspill

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36

Steps to reproduce:

In TB 78.3.1 (x64) create an event. Give it a title and fill in the Location field with a text string. Close the Edit Event dialog.

Actual results:

Depending on the duration of the event and the size/scale/resolution settings of your calendar window and monitor, the Location text string is visible either inside the event block, outside of the block, or straddling the lower border of the block. If the text is white, the portion of it below the graphical event block can be barely visible or invisible.

Expected results:

Location text should only display if there is enough vertical space in the graphical event block to contain it.

Comment 1

[WaltS48 [:walts48]]

Using your example and creating the event to last a half hour, all the text beyond https://us02web.zoom.us disappears for me using 78.3.1 on Ubuntu 18.04 LTS with a 19" monitor.

If I change the event to last an hour all is visible in the event in Day view. It does wrap after https://us02web.zoom.us

I don't see anything showing outside the block.
I'll test on my Windows10 laptop.

Comment 2

[WaltS48 [:walts48]]

Testing with 78.3.1 on Windows10, I can get a faded text in the event block if I place the URL in the Location field.

I put it all in the Title field in my test on Linux. Sorry for that mistake.

Comment 3

[davelabrecque]

Tell us what you mean by "faded." Can you get it to extend beyond the bottom of the event "block" on the calendar one-day view if the event is short enough in duration?

Comment 4

[WaltS48 [:walts48]]

Attachment: faded_text.png

(In reply to davelabrecque from comment #3)

Tell us what you mean by "faded." Can you get it to extend beyond the bottom of the event "block" on the calendar one-day view if the event is short enough in duration?

Yes, I can if the duration is 15 minutes.

I can get it to look like your screenshot with a duration of 40 minutes.

Comment 5

[WaltS48 [:walts48]]

Attachment: dark-theme.png

Using the Thunderbird Dark theme.

Comment 6

[WaltS48 [:walts48]]

I just had a look at 68.10.0 on Ubuntu to see how it appears, and the Location information doesn't appear in the event block in Day view even with an hour or two hour long duration. Just the event title.

It does in the tooltip along with the Title, Date/Time and Calendar.

So, I wonder if that Location information is supposed to appear at all in 78.x.x?

Appears in the block in 68.12.1, Beta 82.0b2, but not in Daily 83.0a1.

Fascinating.

Comment 7

[davelabrecque]

Seems like it would've taken an intentional code change to make it appear. If so, it appears they need to trap for too-small a block size.

I'm new here. What happens next? Now that it's been verified, I mean?

Comment 8

[WaltS48 [:walts48]]

(In reply to davelabrecque from comment #7)

Seems like it would've taken an intentional code change to make it appear. If so, it appears they need to trap for too-small a block size.

I'm new here. What happens next? Now that it's been verified, I mean?

I think the bug here is that Location does appear, shouldn't appear, and only the events Title should be appearing. The rest of the information can be seen in the tool tip.

Comment 9

[Geoff Lankow (:darktrojan)]

Showing the location has been an option since forever. (I didn't know it was a thing either.) You can turn it on or off from the preferences UI.

I'm not sure why it's started overflowing but my bet would be something to do with the layout code rather than a change in the calendar. I guess the thing to do is to constrain the box holding the text and if it overflows that's tough.

(Leaving myself needinfo'ed so I remember to come back to this, but clearing Paul as he's not here any more.)

Comment 10

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/8a81725ff0230661a6a66f675c733d4b87645578/calendar/base/content/calendar-editable-item.js#290

Comment 11

[Dave Labrecque]

Is this self-explanatory to code guys? I'm not a code guy. What does this code do? Does it kill text that would fall outside of (or be cut off by) the box borders by any chance?

Comment 12

[Magnus Melin [:mkmelin]]

I just pointed out where the node is filled. Someone will have to check what css is wrong exactly where.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin [:mkmelin] from comment #12)

I just pointed out where the node is filled. Someone will have to check what css is wrong exactly where.

Comment 14

[Henry Wilkes (they/them) [:henry-x]]

Bug 1694820 means that the location is now vertically cropped if it does not fit.

It can still look bad if text is cropped half-way, but at least it doesn't overflow the container (I think to completely hide the location if it doesn't fit completely vertically would require some javascript). Would others consider this FIXED now?

Comment 15

[Dave Labrecque]

Would not completely fixed if one goes by the originally stated Expected Results for this bug. Perhaps considered fixed if going by the title of this bug as originally stated.

I guess I'd rather not see a fraction of the upper portion of a text string. The OP has spoken. ;)