1668919 - Intermittent [Fission] docshell/test/browser/browser_tab_touch_events.js | Test timed out - | Found a tab after previous test timed out

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=317424264&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/N9ARFoUCTdaoZcBBF8mNhw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-10-02T18:05:01.940Z] 18:05:01     INFO - TEST-PASS | docshell/test/browser/browser_tab_touch_events.js | Newly created frames should use the new touchEventsOverride flag - 0 == 0 - 
[task 2020-10-02T18:05:01.940Z] 18:05:01     INFO - Buffered messages finished
[task 2020-10-02T18:05:01.941Z] 18:05:01     INFO - TEST-UNEXPECTED-FAIL | docshell/test/browser/browser_tab_touch_events.js | Test timed out - 
[task 2020-10-02T18:05:01.942Z] 18:05:01     INFO - GECKO(6943) | MEMORY STAT | vsize 3357MB | residentFast 359MB | heapAllocated 98MB
[task 2020-10-02T18:05:01.942Z] 18:05:01     INFO - TEST-OK | docshell/test/browser/browser_tab_touch_events.js | took 90068ms
[task 2020-10-02T18:05:01.943Z] 18:05:01     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-02T18:05:01.943Z] 18:05:01     INFO - TEST-UNEXPECTED-FAIL | docshell/test/browser/browser_tab_touch_events.js | Found a tab after previous test timed out: data:text/html;charset=utf-8,<iframe id='test-iframe'></iframe> - 
[task 2020-10-02T18:05:01.944Z] 18:05:01     INFO - GECKO(6943) | [Child 7197: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7ff1cc45e400 == 2 [pid = 7197] [id = 57] [url = about:blank]
[task 2020-10-02T18:05:01.945Z] 18:05:01     INFO - GECKO(6943) | [Child 7367: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fbad8bab400 == 1 [pid = 7367] [id = 11]
[task 2020-10-02T18:05:01.945Z] 18:05:01     INFO - GECKO(6943) | [Child 7367: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7fbaf6393180) [pid = 7367] [serial = 28] [outer = (nil)]
[task 2020-10-02T18:05:01.946Z] 18:05:01     INFO - GECKO(6943) | [Child 7367: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7fbad8bac400) [pid = 7367] [serial = 29] [outer = 0x7fbaf6393180]
[task 2020-10-02T18:05:01.946Z] 18:05:01     INFO - checking window state```

Comment 1

[Intermittent Failures Robot]

5 failures in 4195 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4
• mozilla-central: 1

Platform breakdown:

• linux1804-64: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 2

[Intermittent Failures Robot]

45 failures in 4130 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #28 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 43
• mozilla-central: 2

Platform breakdown:

• linux1804-64: 44
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 3

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly milestone M6c.

Comment 4

[Intermittent Failures Robot]

29 failures in 3694 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• autoland: 26
• mozilla-central: 3

Platform breakdown:

• linux1804-64: 27
• windows10-64-shippable-qr: 1
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 5

[Neha Kochar [:neha]]

Masayuki, can you debug this?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm not familiar with touch events, edgar, how about you? If not, I'll take a look (feel free to say "do not have much time").

Comment 7

[Edgar Chen [:edgar]]

Not super familiar, but I could reproduce this locally, I will take a look.

Comment 8

[Edgar Chen [:edgar]]

This actually isn't related to the touch event, the test got timeout because it doesn't receive load event from iframe after calling reload(). Look at the entire history of this intermittent-failure, it starts happening from 2020-10-02 and only on Fission, I suspect there might be some changes cause this issue. Neha, do you know who is the best person to ni? Thanks!

Comment 9

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar] from comment #7)

I could reproduce this locally.

I bisect down manually, it pointers at https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ee7eeea3fb66321fabf86ffd3a1caf4fa3511e43&tochange=1aa67f749387d4d6d26f7d69511434ac71112110, seems to relate to SHIP.

Comment 10

[Intermittent Failures Robot]

37 failures in 4230 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 35
• try: 2

Platform breakdown:

• linux1804-64: 37

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-10-19&endday=2020-10-25&tree=all

Comment 11

[Atila Butkovits]

This bug failed 34 time in the last 7 days.
Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=320336191&repo=mozilla-central&lineNumber=18269

Olli, Peter, could you look into this?

Comment 12

[Intermittent Failures Robot]

36 failures in 4275 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #29 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 30
• mozilla-central: 4
• try: 2

Platform breakdown:

• linux1804-64: 36

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 13

[Dorel Luca [:dluca]]

This bug failed 39 times in the last 7 days. Fails on linux1804-64 and windows10-64-shippable on opt and debug build types.

Recent log:
https://treeherder.mozilla.org/logviewer?job_id=321011638&repo=autoland&lineNumber=11261

Olli, Peter: Any updates on this bug?

Comment 14

[Intermittent Failures Robot]

42 failures in 4128 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #31 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 38
• mozilla-central: 3
• try: 1

Platform breakdown:

• linux1804-64: 39
• windows10-64-shippable: 2
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1668919&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 15

[Intermittent Failures Robot]

18 failures in 4040 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 14
• mozilla-central: 4

Platform breakdown:

• linux1804-64: 16
• windows10-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1668919&startday=2020-11-09&endday=2020-11-15&tree=all

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

In the last 7 days there have been 23 occurrences, most on linux1804-64 debug and some on windows10-64-shippable opt.

Recent failure: https://treeherder.mozilla.org/logviewer?job_id=322550669&repo=mozilla-central&lineNumber=7374

Comment 17

[Intermittent Failures Robot]

23 failures in 4810 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 19
• mozilla-central: 4

Platform breakdown:

• linux1804-64: 20
• windows10-64-shippable: 2
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1668919&startday=2020-11-16&endday=2020-11-22&tree=all

Comment 18

[Intermittent Failures Robot]

9 failures in 1479 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4
• autoland: 5

Platform breakdown:

• linux1804-64: 8
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1668919&startday=2020-11-23&endday=2020-11-29&tree=all

Comment 19

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1668919 - try to make browser_tab_touch_events.js less racy, r=edgar

As far as I see the test is racy. It adds event listener to a window object, which reload() will replace.
So if the load event for non-transient about:blank gets chance to fire, then the test passes without the patch.
The main thing the patch does is to listen for the load event on the iframe element, since that object isn't
replaced.

The intermittent failure happens quite rarely and not locally, so the patch is based on code inspection.
Locally the test was run successfully 100 times both with opt and debug builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b3c65c89c55cd16bf57cf0b78db9ee99ba23df2

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ab108ce38da
try to make browser_tab_touch_events.js less racy, r=edgar

Comment 21

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4ab108ce38da

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 23

[Intermittent Failures Robot]

5 failures in 3712 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 2
• try: 1

Platform breakdown:

• linux1804-64-shippable: 1
• linux1804-64: 3
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1668919&startday=2020-11-30&endday=2020-12-06&tree=all